From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Carl Philipp Klemm <philipp@uvos.xyz>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
Arthur Demchenkov <spinal.by@gmail.com>,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 4/5] power: supply: cpcap-charger: fix small mistake in current to register conversion
Date: Mon, 5 Apr 2021 10:22:01 +0200 [thread overview]
Message-ID: <20210405082201.v2nbm7bsej25uyva@earth.universe> (raw)
In-Reply-To: <YGlpb+AHo/qtLxDI@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
Hi,
On Sun, Apr 04, 2021 at 10:23:27AM +0300, Tony Lindgren wrote:
> * Carl Philipp Klemm <philipp@uvos.xyz> [210117 23:47]:
> > Signed-off-by: Carl Philipp Klemm <philipp@uvos.xyz>
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Thanks, queued.
-- Sebastian
> > ---
> > drivers/power/supply/cpcap-charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> > index 152090faf5b2..be7d1da7a5a5 100644
> > --- a/drivers/power/supply/cpcap-charger.c
> > +++ b/drivers/power/supply/cpcap-charger.c
> > @@ -300,7 +300,7 @@ static int cpcap_charger_current_to_regval(int microamp)
> > return CPCAP_REG_CRM_ICHRG(0x0);
> > if (miliamp < 177)
> > return CPCAP_REG_CRM_ICHRG(0x1);
> > - if (miliamp > 1596)
> > + if (miliamp >= 1596)
> > return CPCAP_REG_CRM_ICHRG(0xe);
> >
> > res = microamp / 88666;
> > --
> > 2.29.2
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-05 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 21:47 [PATCH 4/5] power: supply: cpcap-charger: fix small mistake in current to register conversion Carl Philipp Klemm
2021-04-04 7:23 ` Tony Lindgren
2021-04-05 8:22 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210405082201.v2nbm7bsej25uyva@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=philipp@uvos.xyz \
--cc=spinal.by@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).