From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Adam Ford <aford173@gmail.com>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org
Cc: aford@beaconembedded.com, kernel test robot <lkp@intel.com>,
Andreas Kemnade <andreas@kemnade.info>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Eduardo Valentin <edubezval@gmail.com>,
Keerthy <j-keerthy@ti.com>, Zhang Rui <rui.zhang@intel.com>,
Amit Kucheria <amitk@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management
Date: Fri, 9 Oct 2020 01:23:21 +0200 [thread overview]
Message-ID: <6acd7e51-0c77-fa30-9e8c-d2cf727e512c@linaro.org> (raw)
In-Reply-To: <20200911123157.759379-1-aford173@gmail.com>
On 11/09/2020 14:31, Adam Ford wrote:
> The bandgap sensor can be idled when the processor is too, but it
> isn't currently being done, so the power consumption of OMAP3
> boards can elevated if the bangap sensor is enabled.
>
> This patch attempts to use some additional power management
> to idle the clock to the bandgap when not needed.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Tested-by: Andreas Kemnade <andreas@kemnade.info> # GTA04
> ---
[ ... ]
> - /* First thing is to remove sensor interfaces */
> + cpu_pm_unregister_notifier(&bgp->nb);
> +
> + /* Remove sensor interfaces */
> for (i = 0; i < bgp->conf->sensor_count; i++) {
> if (bgp->conf->sensors[i].unregister_cooling)
> bgp->conf->sensors[i].unregister_cooling(bgp, i);
> @@ -1150,9 +1167,43 @@ static int ti_bandgap_suspend(struct device *dev)
> if (TI_BANDGAP_HAS(bgp, CLK_CTRL))
> clk_disable_unprepare(bgp->fclock);
>
> + bgp->is_suspended = true;
Is this flag really needed?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-10-08 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 12:31 [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management Adam Ford
2020-09-11 12:31 ` [PATCH 2/2] ARM: omap2plus_defconfig: Enable OMAP3_THERMAL Adam Ford
2020-10-16 15:19 ` Adam Ford
2020-11-12 11:34 ` Adam Ford
2020-11-16 8:57 ` Tony Lindgren
2020-10-08 20:59 ` [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management Adam Ford
2020-10-08 23:23 ` Daniel Lezcano [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-18 15:46 Adam Ford
2020-08-18 19:49 ` kernel test robot
2020-08-18 20:01 ` kernel test robot
2020-08-19 4:59 ` Tony Lindgren
2020-08-19 12:21 ` Adam Ford
2020-08-19 12:54 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6acd7e51-0c77-fa30-9e8c-d2cf727e512c@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=amitk@kernel.org \
--cc=andreas@kemnade.info \
--cc=edubezval@gmail.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=rui.zhang@intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).