From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E89C4363A for ; Wed, 28 Oct 2020 22:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B861F2474B for ; Wed, 28 Oct 2020 22:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aTm6r+eM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730818AbgJ1WMQ (ORCPT ); Wed, 28 Oct 2020 18:12:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730813AbgJ1WMQ (ORCPT ); Wed, 28 Oct 2020 18:12:16 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E52B3C0613CF for ; Wed, 28 Oct 2020 15:12:15 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id k25so907317lji.9 for ; Wed, 28 Oct 2020 15:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RwHMd9nNJDrCZQQY9z9MsksS67ghdV6lf0qJYLBuL9w=; b=aTm6r+eMKNxLRMIGLCcKhgs49InOA7XhLbWiAZ8Fd3GUsE1vqdKGuf8yz0Vce4w85e xwvYL3xfpvCD5GJNf6F6behhTYCzHKYlB0JdoR6WmZ/4UUVN18WtIsVlHVUjvxoVxi1N qMGyAVwbrMYiYSqCABbAHPvlSul0iqKmLv6dYMseSxFDtKXeBlK8oa9iD4/GuZ80UTjB HZPIMWrNANB7IoD6R5cZX6dBU6CClzRkAEUz2fOdufW7fjA9YfWado2Q9ylMy3VVyzar anfocd0VImDOQmW8a/1abWI2WWlK0TWl5gqRlGqPb/6SAWtx1XR/8Fbtykrrn2GnCmAD huvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RwHMd9nNJDrCZQQY9z9MsksS67ghdV6lf0qJYLBuL9w=; b=psVzL8LiopwtzEjhtMPFA2/LERq5q0EeiIFePVXzxpX9//76JjZpv8bloglFEiglCC RqTuUStnTrISQXx7GMm+Qrx34VbHDPN7EaLrfnB3j0dbmgA9hNpQdrI93YqrqqRuJqwm 4KHC703Bp/NYZiDf0TmSWzmOKFVVLWnmSKBdKtCkuiFhmhAUW+7jBrMameIew5DrDUYR RSib9LXTHRxyElRpIoy4UPpKNaDsW95rLe16FBvy5oldZW+5qxhGXTY9p0fzsEK4AxDc WgyD9rLhwcDOOr1Q6V/IEHgfY1dFxLcvSsyWBwaKHbKepR345QjPq5MaAVW0CaE5eKbM yE4A== X-Gm-Message-State: AOAM531bMhGJDDvv2AHBSp3ShSuxd3LQY3WxwIj7EzdAcruyk0vdwrLf N514MuOdp9OmUjV3A7J9mFkqbPDEmo5HVfb40XygcNXsmCQMhw== X-Google-Smtp-Source: ABdhPJw939xH2jDNloF2M5EDl+nu2WQP9QKe67iGxQIrEdE6uS+aCV3rNRSgMKCxItJ3JdzJGWrxAgxigoGxnWREM4U= X-Received: by 2002:a19:191:: with SMTP id 139mr2699355lfb.502.1603899685282; Wed, 28 Oct 2020 08:41:25 -0700 (PDT) MIME-Version: 1.0 References: <20201028060556.56038-1-tony@atomide.com> In-Reply-To: <20201028060556.56038-1-tony@atomide.com> From: Linus Walleij Date: Wed, 28 Oct 2020 16:41:14 +0100 Message-ID: Subject: Re: [PATCH] Revert "Revert "gpio: omap: Fix lost edge wake-up interrupts"" To: ext Tony Lindgren Cc: Bartosz Golaszewski , Grygorii Strashko , "open list:GPIO SUBSYSTEM" , Linux-OMAP , Linux ARM , Aaro Koskinen , Keerthy , Ladislav Michl , Peter Ujfalusi , Russell King , Tero Kristo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, Oct 28, 2020 at 7:06 AM Tony Lindgren wrote: > This reverts commit 579ced8fdb00b8e94304a83e3cc419f6f8eab08e. > > Turns out I was overly optimistic about cpu_pm blocking idle being a > solution for handling edge interrupts. While it helps in preventing > entering idle states that potentially lose context, we can still get > an edge interrupt triggering while entering idle. So we need to also > add back the workaround for seeing if there are any pending edge > interrupts when waking up. > > Cc: Aaro Koskinen > Cc: Grygorii Strashko > Cc: Keerthy > Cc: Ladislav Michl > Cc: Peter Ujfalusi > Cc: Russell King > Cc: Tero Kristo > Signed-off-by: Tony Lindgren Patch applied for fixes! Yours, Linus Walleij