RE: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops

From: Peng Fan <peng.fan@nxp.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
	"Lee Jones" <lee@kernel.org>,
	"Daniel Thompson" <daniel.thompson@linaro.org>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Helge Deller" <deller@gmx.de>,
	"Bruno Prémont" <bonbons@linux-vserver.org>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <bentiss@kernel.org>,
	"Alexander Shiyan" <shc_work@mail.ru>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: RE: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops
Date: Wed, 24 Apr 2024 07:05:59 +0000	[thread overview]
Message-ID: <DU0PR04MB941723CDA3A07046823A8A5788102@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20240424-video-backlight-lcd-ops-v2-17-1aaa82b07bc6@kernel.org>

> Subject: [PATCH v2 17/19] fbdev: imx: Constify lcd_ops
> 
> 'struct lcd_ops' is not modified by core backlight code, so it can be made
> const for increased code safety.
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> Depends on the first patch in the series.
> ---
>  drivers/video/fbdev/imxfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index
> a4dbc72f93c3..4ebfe9b9df60 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -857,7 +857,7 @@ static int imxfb_lcd_set_power(struct lcd_device
> *lcddev, int power)
>  	return 0;
>  }
> 
> -static struct lcd_ops imxfb_lcd_ops = {
> +static const struct lcd_ops imxfb_lcd_ops = {
>  	.check_fb	= imxfb_lcd_check_fb,
>  	.get_contrast	= imxfb_lcd_get_contrast,
>  	.set_contrast	= imxfb_lcd_set_contrast,
> 
> --
> 2.43.0
>