From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com, Linux-OMAP <linux-omap@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jyri Sarha <jsarha@ti.com>
Subject: OMAP5: inconsistency between target-module and dsi_of_data_omap5
Date: Sun, 5 Jul 2020 08:52:16 +0200 [thread overview]
Message-ID: <F5C04FAF-0029-48F3-B0A6-5327CD911EA2@goldelico.com> (raw)
Hi Tony,
since v5.7-rc1 our Pyra (OMAP5) dsi panel doesn't initialize and we do not
get a /dev/fb0.
There is a suspicious log message:
[ 15.352314] DSI: omapdss DSI error: unsupported DSI module
I could trace it down to be likely a discrepancy between
target-module@58000000 {
...
target-module@5000 {
compatible = "ti,sysc-omap2", "ti,sysc";
reg = <0x5000 0x4>,
...
ranges = <0 0x5000 0x1000>;
dsi1: encoder@0 {
compatible = "ti,omap5-dsi";
target-module@9000 {
compatible = "ti,sysc-omap2", "ti,sysc";
reg = <0x9000 0x4>,
<0x9010 0x4>,
<0x9014 0x4>;
...
ranges = <0 0x9000 0x1000>;
dsi2: encoder@0 {
compatible = "ti,omap5-dsi";
reg = <0 0x200>,
<0x200 0x40>,
<0x300 0x40>;
and
static const struct dsi_of_data dsi_of_data_omap5 = {
.model = DSI_MODEL_OMAP5,
.pll_hw = &dss_omap5_dsi_pll_hw,
.modules = (const struct dsi_module_id_data[]) {
{ .address = 0x58004000, .id = 0, },
{ .address = 0x58009000, .id = 1, },
{ },
},
Therefore the address match logic in dsi_probe() fails and ends in
the mentioned log message.
Looking at git blame, the DTS was recently changed by 5a507162f096b54.
Commit 98e1a6a86a22d62 did do a similar change for dsi2 but did not
modify the address.
So I wonder if the 0x5000 is just a typo or if there is something
where the dsi1: encoder@0 should have a negative offset to end
up at address 0x58004000?
BR and thanks,
Nikolaus
next reply other threads:[~2020-07-05 6:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 6:52 H. Nikolaus Schaller [this message]
2020-07-05 7:40 ` OMAP5: inconsistency between target-module and dsi_of_data_omap5 H. Nikolaus Schaller
2020-07-05 13:47 ` H. Nikolaus Schaller
2020-07-05 14:26 ` Tony Lindgren
2020-07-05 14:36 ` Tony Lindgren
2020-07-05 15:40 ` H. Nikolaus Schaller
2020-07-06 14:36 ` Tony Lindgren
2020-07-06 16:10 ` H. Nikolaus Schaller
2020-07-07 18:01 ` Tony Lindgren
2020-07-07 19:04 ` H. Nikolaus Schaller
2020-07-08 7:52 ` OMAP5: inconsistency between target-module and dsi_of_data_omap5 / module_mipi_dsi_driver panel with omapdrm H. Nikolaus Schaller
2020-07-23 7:03 ` Re:module_mipi_dsi_driver panel with omapdrm? H. Nikolaus Schaller
2020-07-24 1:24 ` module_mipi_dsi_driver " Laurent Pinchart
2020-07-24 5:50 ` H. Nikolaus Schaller
2020-08-01 13:43 ` H. Nikolaus Schaller
2020-08-01 23:22 ` Sebastian Reichel
2020-08-05 9:19 ` H. Nikolaus Schaller
2020-08-05 11:28 ` Sebastian Reichel
2020-08-05 11:49 ` H. Nikolaus Schaller
2020-08-05 12:08 ` Tomi Valkeinen
2020-08-06 15:50 ` David Shah
2020-08-06 16:04 ` [Letux-kernel] " David Shah
2020-08-06 18:44 ` David Shah
2020-08-06 19:01 ` H. Nikolaus Schaller
2020-08-06 19:44 ` David Shah
2020-08-07 6:53 ` Tomi Valkeinen
2020-08-16 11:24 ` H. Nikolaus Schaller
2020-08-18 9:16 ` Tony Lindgren
2020-08-04 12:43 ` Tomi Valkeinen
2020-08-05 9:25 ` H. Nikolaus Schaller
2020-08-05 11:07 ` Sebastian Reichel
2020-08-05 11:14 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F5C04FAF-0029-48F3-B0A6-5327CD911EA2@goldelico.com \
--to=hns@goldelico.com \
--cc=jsarha@ti.com \
--cc=kernel@pyra-handheld.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).