From: Luis Chamberlain <mcgrof@kernel.org>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, axboe@kernel.dk, efremov@linux.com,
josef@toxicpanda.com, idryomov@gmail.com,
dongsheng.yang@easystack.cn, haris.iqbal@ionos.com,
jinpu.wang@ionos.com, mst@redhat.com, jasowang@redhat.com,
pbonzini@redhat.com, stefanha@redhat.com, ohad@wizery.com,
andersson@kernel.org, baolin.wang@linux.alibaba.com,
ulf.hansson@linaro.org, richard@nod.at,
miquel.raynal@bootlin.com, vigneshr@ti.com, marcan@marcan.st,
sven@svenpeter.dev, alyssa@rosenzweig.io, kbusch@kernel.org,
hch@lst.de, sagi@grimberg.me, sth@linux.ibm.com,
hoeppner@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, hare@suse.de, bhelgaas@google.com,
john.garry@huawei.com, christophe.jaillet@wanadoo.fr,
vaibhavgupta40@gmail.com, wsa+renesas@sang-engineering.com,
damien.lemoal@opensource.wdc.com, johannes.thumshirn@wdc.com,
bvanassche@acm.org, ming.lei@redhat.com,
shinichiro.kawasaki@wdc.com, vincent.fu@samsung.com,
christoph.boehmwalder@linbit.com, joel@jms.id.au,
vincent.whitchurch@axis.com, nbd@other.debian.org,
ceph-devel@vger.kernel.org,
virtualization@lists.linux-foundation.org, asahi@lists.linux.dev
Subject: Re: [RFC PATCH 00/21] block: add and use init tagset helper
Date: Fri, 7 Oct 2022 11:26:13 -0700 [thread overview]
Message-ID: <Y0BvRaVO0iUVmHgB@bombadil.infradead.org> (raw)
In-Reply-To: <20221005032257.80681-1-kch@nvidia.com>
On Tue, Oct 04, 2022 at 08:22:36PM -0700, Chaitanya Kulkarni wrote:
> Hi,
>
> Add and use the helper to initialize the common fields of the tag_set
> such as blk_mq_ops, number of h/w queues, queue depth, command size,
> numa_node, timeout, BLK_MQ_F_XXX flags, driver data. This initialization
> is spread all over the block drivers. This avoids repetation of
> inialization code of the tag set in current block drivers and any future
> ones.
>
> P.S. I'm aware of the EXPORT_SYMBOL_GPL() checkpatch warn just to make
> get some feedback to so I can remove the RFC tag.
>
*If* there were commonalities at init and these could be broken up into
common groups, each having their own set of calls, then we simplify and
can abstract these. I say this without doing a complete review of the
removals, but if there really isn't much of commonalities I tend to
agree with Bart that open coding this is better.
Luis
next prev parent reply other threads:[~2022-10-07 18:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 3:22 [RFC PATCH 00/21] block: add and use init tagset helper Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 01/21] " Chaitanya Kulkarni
2022-10-05 5:11 ` Damien Le Moal
2022-10-05 9:47 ` Ulf Hansson
2022-10-05 16:54 ` Bart Van Assche
2022-10-05 3:22 ` [RFC PATCH 02/21] loop: use lib tagset init helper Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 03/21] nbd: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 04/21] rnbd: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 05/21] bsg-lib: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 06/21] rnbd-clt: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 07/21] virtio-blk: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 08/21] scsi: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 09/21] block: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 10/21] amiflop: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 11/21] floppy: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 12/21] mtip32xx: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 13/21] z3ram: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 14/21] scm_blk: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 15/21] ubi: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 16/21] mmc: core: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 17/21] dasd: " Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 18/21] nvme-core: use lib tagset init helper for I/O q Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 19/21] nvme-core: use lib tagset init helper for adminq Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 20/21] nvme-apple: use lib tagset init helper Chaitanya Kulkarni
2022-10-05 3:22 ` [RFC PATCH 21/21] nvme-pci: " Chaitanya Kulkarni
2022-10-07 18:26 ` Luis Chamberlain [this message]
2022-10-10 7:55 ` [RFC PATCH 00/21] block: add and use init tagset helper Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0BvRaVO0iUVmHgB@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=alyssa@rosenzweig.io \
--cc=andersson@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=axboe@kernel.dk \
--cc=baolin.wang@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=borntraeger@linux.ibm.com \
--cc=bvanassche@acm.org \
--cc=ceph-devel@vger.kernel.org \
--cc=christoph.boehmwalder@linbit.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dongsheng.yang@easystack.cn \
--cc=efremov@linux.com \
--cc=gor@linux.ibm.com \
--cc=hare@suse.de \
--cc=haris.iqbal@ionos.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=idryomov@gmail.com \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@ionos.com \
--cc=joel@jms.id.au \
--cc=johannes.thumshirn@wdc.com \
--cc=john.garry@huawei.com \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=ohad@wizery.com \
--cc=pbonzini@redhat.com \
--cc=richard@nod.at \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stefanha@redhat.com \
--cc=sth@linux.ibm.com \
--cc=sven@svenpeter.dev \
--cc=svens@linux.ibm.com \
--cc=ulf.hansson@linaro.org \
--cc=vaibhavgupta40@gmail.com \
--cc=vigneshr@ti.com \
--cc=vincent.fu@samsung.com \
--cc=vincent.whitchurch@axis.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).