From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26CFDC0650E for ; Wed, 3 Jul 2019 14:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB47A21850 for ; Wed, 3 Jul 2019 14:30:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="G8DIj1ry"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="G8DIj1ry" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726991AbfGCOaX (ORCPT ); Wed, 3 Jul 2019 10:30:23 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:43218 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbfGCOaX (ORCPT ); Wed, 3 Jul 2019 10:30:23 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id AF8008EE1DD; Wed, 3 Jul 2019 07:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1562164222; bh=aPdHhGlcAshCfEwTUbZJ7vkpiTSNUOVLBZFUotCd/MQ=; h=Subject:From:To:Date:In-Reply-To:References:From; b=G8DIj1ryOXQxcP3DvW5AP4EqNVW7e/oxukxeAzeMoCbWbcSyZZMEa4ApFrSEgwWye ky1uv/q+b+Fqj8IdtyaTGuPqsZDHuFandE+oL0PpPrPFWfG95WvDIbUXFnarpZtcCG H9UIoSHwhgKlhS9nm914iqhNCZtSiHY107CpIm/g= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fDJZ0orGIq3y; Wed, 3 Jul 2019 07:30:22 -0700 (PDT) Received: from jarvis.lan (unknown [50.35.68.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 21F508EE0D5; Wed, 3 Jul 2019 07:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1562164222; bh=aPdHhGlcAshCfEwTUbZJ7vkpiTSNUOVLBZFUotCd/MQ=; h=Subject:From:To:Date:In-Reply-To:References:From; b=G8DIj1ryOXQxcP3DvW5AP4EqNVW7e/oxukxeAzeMoCbWbcSyZZMEa4ApFrSEgwWye ky1uv/q+b+Fqj8IdtyaTGuPqsZDHuFandE+oL0PpPrPFWfG95WvDIbUXFnarpZtcCG H9UIoSHwhgKlhS9nm914iqhNCZtSiHY107CpIm/g= Message-ID: <1562164221.3438.3.camel@HansenPartnership.com> Subject: Re: [PATCH] palo: fix IPL overlap with ext2/ext3 resize_inode From: James Bottomley To: Helge Deller , Parisc List Date: Wed, 03 Jul 2019 07:30:21 -0700 In-Reply-To: <67376425-6e29-3b20-a0aa-7fce2c030366@gmx.de> References: <1562131344.29304.100.camel@HansenPartnership.com> <67376425-6e29-3b20-a0aa-7fce2c030366@gmx.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Wed, 2019-07-03 at 07:53 +0200, Helge Deller wrote: > On 03.07.19 07:22, James Bottomley wrote: > > palo is producing corrupt filesystems because ext2 can't cope with > > any of the resize_inode, which is traditionally placed at blocks 3- > > 258, being in the badblocks list. If this happens, mke2fs silently > > produces a corrupt filesystem image and the palo partition will > > eventually trigger a filesystem error. The fix is to force palo to > > specify -O^resize_inode to mke2fs which prevents ext2/3 from > > allocating a resize_inode (and thus prevents the filesystem from > > being > > resized). > > > > Signed-off-by: James Bottomley > om> > > --- > > palo/palo.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/palo/palo.c b/palo/palo.c > > index 68b85cf..e088993 100644 > > --- a/palo/palo.c > > +++ b/palo/palo.c > > @@ -443,7 +443,11 @@ do_cdrom(int media, int kernel32, int > > kernel64, > > #define EXT2_HOLE ((MAXBLSIZE + 1) / EXT2_BLOCKSIZE) > > > > /* offset in bytes before start of hole, ext2 doesn't allow > > holes at > > - * to cover the first four blocks of the filesystem */ > > + * to cover the first four blocks of the filesystem > > + * > > + * Note: modern ext2/3 has a resize_inode covering blocks 3-258 so > > you > > + * must either always include the -O^resize_inode when creating > > the > > + * filesystem or define EXT2_OFFSET to (259*EXT2_BLOCKSIZE)*/ > > #define EXT2_OFFSET (4*EXT2_BLOCKSIZE) > > > > int > > @@ -502,7 +506,7 @@ do_formatted(int init, int media, const char > > *medianame, int partition, > > } > > } > > > > - sprintf(cmd, "mke2fs %s -b %d -l %s %s", do_format == 3 ? > > "-j" : "", > > + sprintf(cmd, "mke2fs %s -O^resize_inode -b %d -l %s %s", > > do_format == 3 ? "-j" : "", > > What happens if we face an "old" mke2fs binary which doesn't know > about this feature and thus fails? > I wonder if it makes sense to add a fallback path? It would fail according to my tests. It's a bit unlikely that anyone who's updating palo is not also updating the rest of their system, and even when parisc fell off debian we had a version of mke2fs recent enough to understand resize inodes because the feature was introduced in 2006. The other alternative is simply to change EXT2_OFFSET to always not clash with the resize inode ... that would work for all cases. James