From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Denis Efremov <efremov@linux.com>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: asm: psw.h: missing header guard
Date: Sun, 23 Jun 2019 18:01:41 +0200 [thread overview]
Message-ID: <8264763.oMOxLtkXCx@daneel.sf-tec.de> (raw)
In-Reply-To: <20190623150920.26422-1-efremov@linux.com>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
Denis Efremov wrote:
> The psw.h header file contains #ifndef directive of the guard,
> but the complimentary #define directive is missing. The patch
> adds the appropriate #define to fix the header guard.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> arch/parisc/include/asm/psw.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
> index 76c301146c31..7a175e866ed0 100644
> --- a/arch/parisc/include/asm/psw.h
> +++ b/arch/parisc/include/asm/psw.h
> @@ -1,5 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #ifndef _PARISC_PSW_H
> +#define _PARISC_PSW_H
>
>
> #define PSW_I 0x00000001
You could have removed one of the 2 empty lines then.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-06-23 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 15:09 [PATCH] parisc: asm: psw.h: missing header guard Denis Efremov
2019-06-23 16:01 ` Rolf Eike Beer [this message]
2019-06-24 8:44 ` Denis Efremov
2019-06-24 8:51 ` [PATCH v2] " Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8264763.oMOxLtkXCx@daneel.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).