From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB4EC48BDB for ; Mon, 8 Jul 2019 01:15:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3CF120693 for ; Mon, 8 Jul 2019 01:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727976AbfGHBPo (ORCPT ); Sun, 7 Jul 2019 21:15:44 -0400 Received: from ozlabs.org ([203.11.71.1]:46577 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727949AbfGHBPn (ORCPT ); Sun, 7 Jul 2019 21:15:43 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45hnZJ0R8Jz9sN4; Mon, 8 Jul 2019 11:15:35 +1000 (AEST) From: Michael Ellerman To: Aleksa Sarai , Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan Cc: Aleksa Sarai , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Christian Brauner , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Aleksa Sarai , Linus Torvalds , containers@lists.linux-foundation.org, linux-alpha@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v9 10/10] selftests: add openat2(2) selftests In-Reply-To: <20190706145737.5299-11-cyphar@cyphar.com> References: <20190706145737.5299-1-cyphar@cyphar.com> <20190706145737.5299-11-cyphar@cyphar.com> Date: Mon, 08 Jul 2019 11:15:35 +1000 Message-ID: <878st9iax4.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Hi Aleksa, A few minor comments below. Aleksa Sarai writes: > diff --git a/tools/testing/selftests/openat2/Makefile b/tools/testing/selftests/openat2/Makefile > new file mode 100644 > index 000000000000..8235a49928f6 > --- /dev/null > +++ b/tools/testing/selftests/openat2/Makefile > @@ -0,0 +1,12 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +CFLAGS += -Wall -O2 -g > +TEST_GEN_PROGS := linkmode_test resolve_test rename_attack_test > + > +include ../lib.mk > + > +$(OUTPUT)/linkmode_test: linkmode_test.c helpers.o > +$(OUTPUT)/rename_attack_test: rename_attack_test.c helpers.o > +$(OUTPUT)/resolve_test: resolve_test.c helpers.o You don't need to tell make that foo depends on foo.c. Also if you make the dependency be on helpers.c then you won't get an intermediate helpers.o, and then you don't need to clean it. So the above three lines could just be: $(TEST_GEN_PROGS): helpers.c > +EXTRA_CLEAN = helpers.o $(wildcard /tmp/ksft-openat2-*) If you follow my advice above you don't need helpers.o in there. Deleting things from /tmp is also a bit fishy on shared machines, ie. it will error if those files happen to be owned by another user. cheers