From: Guenter Roeck <linux@roeck-us.net>
To: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: Regenerate parisc defconfigs
Date: Thu, 26 Mar 2020 23:43:01 -0700 [thread overview]
Message-ID: <d83868cb-12cd-054e-db85-bcbb9121683a@roeck-us.net> (raw)
In-Reply-To: <20200326221921.GA20495@ls3530.fritz.box>
On 3/26/20 3:19 PM, Helge Deller wrote:
> * Guenter Roeck <linux@roeck-us.net>:
>> On Mon, Feb 03, 2020 at 10:31:22PM +0100, Helge Deller wrote:
>>> Regenerate the 32- and 64-bit defconfigs and drop the outdated specific
>>> machine defconfigs for the 712, A500, B160, C3000 and C8000 workstations.
>>> ---
>>> arch/parisc/configs/712_defconfig | 181 ---------------
>>> arch/parisc/configs/a500_defconfig | 177 ---------------
>>> arch/parisc/configs/defconfig | 206 -----------------
>>
>> Since the removal of arch/parisc/configs/defconfig, "make ARCH=parisc
>> defconfig" results in an endless recursive make loop.
>
> Can you please test the patch below?
> Helge
>
> ----
> [PATCH] parisc: Fix defconfig selection
>
> Fix the recursive loop when running "make ARCH=parisc defconfig".
>
> Fixes: 84669923e1ed ("parisc: Regenerate parisc defconfigs")
> Noticed-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Helge Deller <deller@gmx.de>
This works.
Tested-by: Guenter Roeck <linux@roeck-us.net>
It would be nice if there was a better way to select 32-bit
vs. 64-bit defconfigs (for example based on the compiler,
or with ARCH={parisc,parisc64}). However, that never worked
for parisc, so I guess we can't expect it to magically work
now, and much less so for a bug fix.
Thanks,
Guenter
>
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index 71034b54d74e..3801a2ef9bca 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -79,6 +79,11 @@ config MMU
> config STACK_GROWSUP
> def_bool y
>
> +config ARCH_DEFCONFIG
> + string
> + default "arch/parisc/configs/generic-32bit_defconfig" if !64BIT
> + default "arch/parisc/configs/generic-64bit_defconfig" if 64BIT
> +
> config GENERIC_LOCKBREAK
> bool
> default y
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index dca8f2de8cf5..628cd8bb7ad8 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -34,6 +34,13 @@ CC_ARCHES = hppa hppa2.0 hppa1.1
> LD_BFD := elf32-hppa-linux
> endif
>
> +# select defconfig based on actual architecture
> +ifeq ($(shell uname -m),parisc64)
> + KBUILD_DEFCONFIG := generic-64bit_defconfig
> +else
> + KBUILD_DEFCONFIG := generic-32bit_defconfig
> +endif
> +
> export LD_BFD
>
> ifneq ($(SUBARCH),$(UTS_MACHINE))
>
next prev parent reply other threads:[~2020-03-27 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 20:20 [PATCH] parisc: Regenerate parisc defconfigs Guenter Roeck
2020-03-26 22:19 ` Helge Deller
2020-03-26 22:47 ` James Bottomley
2020-03-26 23:01 ` Helge Deller
2020-03-27 6:43 ` Guenter Roeck [this message]
2020-03-27 12:28 ` John David Anglin
2020-03-27 14:24 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2020-02-03 21:28 Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d83868cb-12cd-054e-db85-bcbb9121683a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).