From: Marek Vasut <marek.vasut@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
Kazufumi Ikeda <kaz-ikeda@xc.jp.nec.com>,
Gaku Inami <gaku.inami.xw@bp.renesas.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>,
linux-renesas-soc@vger.kernel.org,
Vaibhav Gupta <vaibhavgupta40@gmail.com>
Subject: Re: [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver
Date: Sun, 26 Apr 2020 14:32:53 +0200 [thread overview]
Message-ID: <00f200a9-ab61-a04f-a16c-09a2b0343d3f@gmail.com> (raw)
In-Reply-To: <20200424195724.GA187563@google.com>
On 4/24/20 9:57 PM, Bjorn Helgaas wrote:
Hi,
[...]
>> @@ -1234,6 +1295,7 @@ static int rcar_pcie_resume_noirq(struct device *dev)
>> }
>>
>> static const struct dev_pm_ops rcar_pcie_pm_ops = {
>> + SET_SYSTEM_SLEEP_PM_OPS(NULL, rcar_pcie_resume)
>
> This causes the following warning when CONFIG_PM_SLEEP is not set:
>
> drivers/pci/controller/pcie-rcar.c:1253:12: warning: ‘rcar_pcie_resume’ defined but not used [-Wunused-function]
> 1253 | static int rcar_pcie_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~
>
> Most people seem to be using __maybe_unused on the suspend/resume
> functions to avoid this, e.g., 226e6b866d74 ("gpio: pch: Convert to
> dev_pm_ops").
Should be fixed by:
PCI: pcie-rcar: Mark rcar_pcie_resume() with __maybe_unused
prev parent reply other threads:[~2020-04-26 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 19:12 [PATCH V3] PCI: rcar: Add the suspend/resume for pcie-rcar driver marek.vasut
2020-03-20 10:12 ` Lorenzo Pieralisi
2020-04-26 12:33 ` Marek Vasut
2020-04-24 11:54 ` Lorenzo Pieralisi
2020-04-24 19:57 ` Bjorn Helgaas
2020-04-25 8:55 ` Geert Uytterhoeven
2020-04-27 17:41 ` Bjorn Helgaas
2020-04-27 20:08 ` Geert Uytterhoeven
2020-04-28 8:26 ` Lorenzo Pieralisi
2020-04-28 8:33 ` Geert Uytterhoeven
2020-04-26 12:32 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00f200a9-ab61-a04f-a16c-09a2b0343d3f@gmail.com \
--to=marek.vasut@gmail.com \
--cc=gaku.inami.xw@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=helgaas@kernel.org \
--cc=horms+renesas@verge.net.au \
--cc=kaz-ikeda@xc.jp.nec.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=phil.edworthy@renesas.com \
--cc=vaibhavgupta40@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).