From: Vidya Sagar <vidyas@nvidia.com>
To: "Krzysztof Wilczyński" <kw@linux.com>,
"Shradha Todi" <shradha.t@samsung.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>,
<lorenzo.pieralisi@arm.com>, <robh@kernel.org>,
<bhelgaas@google.com>, <pankaj.dubey@samsung.com>,
<p.rajanbabu@samsung.com>, <hari.tv@samsung.com>,
<niyas.ahmed@samsung.com>, <l.mehra@samsung.com>
Subject: Re: [PATCH 1/3] PCI: dwc: Add support for vendor specific capability search
Date: Thu, 27 May 2021 17:19:02 +0530 [thread overview]
Message-ID: <0e6f5671-1d24-c43f-828a-4002562ec4ef@nvidia.com> (raw)
In-Reply-To: <20210521233100.GB79835@rocinante.localdomain>
On 5/22/2021 5:01 AM, Krzysztof Wilczyński wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Shradha,
>
> [...]
>> +u16 dw_pcie_find_vsec_capability(struct dw_pcie *pci, u8 vsec_cap)
>> +{
>> + u16 vsec = 0;
>> + u32 header;
>> +
>> + while ((vsec = dw_pcie_find_next_ext_capability(pci, vsec,
>> + PCI_EXT_CAP_ID_VNDR))) {
>> + header = dw_pcie_readl_dbi(pci, vsec + PCI_VNDR_HEADER);
>> + if (PCI_VNDR_HEADER_ID(header) == vsec_cap)
>> + return vsec;
>> + }
>> +
>> + return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(dw_pcie_find_vsec_capability);
>
> A small question as I am curious: why not use pci_find_vsec_capability()
> here? The implementation looks very similar, which is why I am asking,
> but it might be that I am missing something, and for that I apologise in
> advance.
pci_find_vsec_capability() expects struct pci_dev * which we get only
after enumeration is done. In the current scenario, we are still in
pre-link up phase and don't have struct pci_dev * yet, hence this
implementation, right Shradha??
>
> Krzysztof
>
next prev parent reply other threads:[~2021-05-27 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210518173814epcas5p46b312c35e11c130a6a8d043f10d12ee4@epcas5p4.samsung.com>
2021-05-18 17:46 ` [PATCH 0/3] Add support for RAS DES feature in PCIe DW controller Shradha Todi
[not found] ` <CGME20210518173819epcas5p1ea10c2748b4bb0687184ff04a7a76796@epcas5p1.samsung.com>
2021-05-18 17:46 ` [PATCH 1/3] PCI: dwc: Add support for vendor specific capability search Shradha Todi
2021-05-21 23:31 ` Krzysztof Wilczyński
2021-05-27 11:49 ` Vidya Sagar [this message]
2021-05-27 11:54 ` Vidya Sagar
[not found] ` <CGME20210518173823epcas5p1cb9f93e209ca4055365048287ec43ee8@epcas5p1.samsung.com>
2021-05-18 17:46 ` [PATCH 2/3] PCI: debugfs: Add support for RAS framework in DWC Shradha Todi
2021-05-21 19:57 ` Bjorn Helgaas
2021-05-21 23:25 ` Krzysztof Wilczyński
2021-05-27 17:20 ` Vidya Sagar
[not found] ` <CGME20210518173826epcas5p32f6b141c9ab4b33e88638cf90a502ef1@epcas5p3.samsung.com>
2021-05-18 17:46 ` [PATCH 3/3] PCI: dwc: Create debugfs files in DWC driver Shradha Todi
2021-05-21 20:04 ` Bjorn Helgaas
2021-05-27 11:53 ` Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e6f5671-1d24-c43f-828a-4002562ec4ef@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hari.tv@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=l.mehra@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=niyas.ahmed@samsung.com \
--cc=p.rajanbabu@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).