From: Jiang Liu <jiang.liu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Borislav Petkov <bp@alien8.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Daniel Vetter <daniel@ffwll.ch>,
Alex Deucher <alexdeucher@gmail.com>,
Christian Knig <christian.koenig@amd.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-iommu@vger.kernel.org, linux-acpi@vger.kernel.org,
x86@kernel.org
Subject: [Bugfix v4 0/2] Prevent binding PCI drivers to PCI devices used by non-pci drivers
Date: Fri, 9 Oct 2015 22:07:30 +0800 [thread overview]
Message-ID: <1444399652-25920-1-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1444386214-26319-1-git-send-email-joro@8bytes.org>
Hi Joerg,
I prepared this patchset yesterday but forgot to send them out.
I think it still worth sending out for review, so here we go:)
---
Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and
pcibios_free_irq()") breaks suspend/resume on some AMD platforms.
The root cause is:
1) AMD IOMMU drivers enables MSI on IOMMU PCI devices at early boot stage
2) PCI driver binding code tries to allocate/free PCI legacy IRQ when
binding other PCI drivers to IOMMU PCI devices at later boot stage,
and breaks PCI MSI allocation information.
3) System resume breaks when restoring PCI MSI state using the damaged
data.
We have tried on solution to detect that a PCI is in use by IOMMU driver
by checking pci_msi_enabled(). But that's too specific, actually we should
prevent binding PCI drivers to PCI devices used by non-PCI drivers.
Fortunately, we could prevent binding PCI drivers to PCI devices by setting
pci_dev->match_driver to false. If needed, we could implement a helper
function to manipulate pci_dev->match_driver.
Jiang Liu (2):
iommu/amd: Prevent binding other PCI drivers to IOMMU PCI devices
ACPI, PCI: Prevent binding other PCI drivers to IOAPIC PCI devices
drivers/acpi/ioapic.c | 7 +++++--
drivers/iommu/amd_iommu_init.c | 3 +++
2 files changed, 8 insertions(+), 2 deletions(-)
--
1.7.10.4
next prev parent reply other threads:[~2015-10-09 14:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 10:23 [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Joerg Roedel
2015-10-09 10:26 ` Thomas Gleixner
2015-10-09 14:07 ` Jiang Liu [this message]
2015-10-09 14:07 ` [Bugfix v4 1/2] iommu/amd: Prevent binding other PCI drivers to IOMMU PCI devices Jiang Liu
2015-10-09 15:56 ` Joerg Roedel
2015-10-09 14:07 ` [Bugfix v4 2/2] ACPI, PCI: Prevent binding other PCI drivers to IOAPIC " Jiang Liu
2015-10-09 15:45 ` Joerg Roedel
2015-10-21 16:23 ` [PATCH] x86/PCI: Don't alloc pcibios-irq when MSI is enabled Bjorn Helgaas
2015-10-23 2:02 ` Jiang Liu
2015-10-23 8:23 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444399652-25920-1-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=alexdeucher@gmail.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=joro@8bytes.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iommu@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).