From: "Derrick, Jonathan" <jonathan.derrick@intel.com>
To: "Busch, Keith" <keith.busch@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"okaya@kernel.org" <okaya@kernel.org>,
"willy@infradead.org" <willy@infradead.org>,
"liudongdong3@huawei.com" <liudongdong3@huawei.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"poza@codeaurora.org" <poza@codeaurora.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter
Date: Thu, 16 Aug 2018 21:28:45 +0000 [thread overview]
Message-ID: <1534454924.13356.1.camel@intel.com> (raw)
In-Reply-To: <20180816211940.GB7400@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Thu, 2018-08-16 at 15:19 -0600, Keith Busch wrote:
> On Thu, Aug 16, 2018 at 01:50:42PM -0700, Derrick, Jonathan wrote:
> > It can also be disabled with setpci, but is that any less of a
> > hassle?
> > Genuine question to understand your point of view.
>
> That is not a real solution, IMO. 'setpci' is good to inject things
> for testing, but it changes config space without the kernel aware
> that
> you've done that, so it is inherently racey with other kernel threads
> touching pci config space. And the kernel or platform may end up
> undoing
> what you had 'setpci' do anyway with no immediate way to be notified
> it
> was changed.
It sounds like a sysfs toggle could be useful regardless of the boot
parameter.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3278 bytes --]
next prev parent reply other threads:[~2018-08-16 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 21:26 [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter Jon Derrick
2018-08-15 21:26 ` [PATCH 2/2] Documentation: Document pci=nodpc Jon Derrick
2018-08-15 23:03 ` [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter Keith Busch
2018-08-16 9:27 ` poza
2018-08-16 15:45 ` Derrick, Jonathan
2018-08-16 15:49 ` Matthew Wilcox
2018-08-16 15:50 ` Derrick, Jonathan
2018-08-16 20:31 ` Bjorn Helgaas
2018-08-16 20:50 ` Derrick, Jonathan
2018-08-16 21:19 ` Keith Busch
2018-08-16 21:28 ` Derrick, Jonathan [this message]
2018-08-17 14:25 ` Bjorn Helgaas
2018-08-17 14:45 ` Derrick, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534454924.13356.1.camel@intel.com \
--to=jonathan.derrick@intel.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).