From: Honghui Zhang <honghui.zhang@mediatek.com>
To: kbuild test robot <lkp@intel.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: <kbuild-all@01.org>, <linux-pci@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [pci:pci/portdrv 1/1] drivers/pci/pcie/portdrv_pci.c:187:9: sparse: warning: Initializer entry defined twice
Date: Fri, 15 Feb 2019 16:18:43 +0800 [thread overview]
Message-ID: <1550218723.4980.69.camel@mhfsdcap03> (raw)
In-Reply-To: <201902151544.kWECyQ24%fengguang.wu@intel.com>
On Fri, 2019-02-15 at 15:34 +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/portdrv
> head: b4f663e35a545fbdc71b3bbf2df88ef9f124a3fa
> commit: b4f663e35a545fbdc71b3bbf2df88ef9f124a3fa [1/1] PCI/portdrv: Support PCIe services on subtractive decode bridges
> reproduce:
> # apt-get install sparse
> git checkout b4f663e35a545fbdc71b3bbf2df88ef9f124a3fa
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/pci/pcie/portdrv_pci.c:187:9: sparse: warning: Initializer entry defined twice
> drivers/pci/pcie/portdrv_pci.c:189:9: sparse: also defined here
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/pci/pcie/portdrv_pci.c:187:9: sparse: warning: Initializer entry defined twice
> >> drivers/pci/pcie/portdrv_pci.c:189:9: sparse: also defined here
>
> vim +187 drivers/pci/pcie/portdrv_pci.c
>
> ^1da177e Linus Torvalds 2005-04-16 181
> ^1da177e Linus Torvalds 2005-04-16 182 /*
> ^1da177e Linus Torvalds 2005-04-16 183 * LINUX Device Driver Model
> ^1da177e Linus Torvalds 2005-04-16 184 */
> ^1da177e Linus Torvalds 2005-04-16 185 static const struct pci_device_id port_pci_ids[] = { {
> ^1da177e Linus Torvalds 2005-04-16 186 /* handle any PCI-Express port */
> ^1da177e Linus Torvalds 2005-04-16 @187 PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0),
> b4f663e3 Honghui Zhang 2019-02-14 188 /* subtractive decode PCI-to-PCI bridge, class type is 060401h */
> b4f663e3 Honghui Zhang 2019-02-14 @189 PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x01), ~0),
> ^1da177e Linus Torvalds 2005-04-16 190 }, { /* end: all zeroes */ }
> ^1da177e Linus Torvalds 2005-04-16 191 };
> ^1da177e Linus Torvalds 2005-04-16 192
>
Hi, Bjorn,
Do you think drop this one, and I send a new version is a good idea? Or
will you re-consider the first version patch?
Thanks.
> :::::: The code at line 187 was first introduced by commit
> :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
>
> :::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
> :::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next parent reply other threads:[~2019-02-15 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201902151544.kWECyQ24%fengguang.wu@intel.com>
2019-02-15 8:18 ` Honghui Zhang [this message]
2019-02-15 20:00 ` [pci:pci/portdrv 1/1] drivers/pci/pcie/portdrv_pci.c:187:9: sparse: warning: Initializer entry defined twice Bjorn Helgaas
2019-02-18 0:42 ` Honghui Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550218723.4980.69.camel@mhfsdcap03 \
--to=honghui.zhang@mediatek.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).