From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <rjw@rjwysocki.net>, <lenb@kernel.org>, <rui.zhang@intel.com>,
<bhelgaas@google.com>
Cc: Xiaofei Tan <tanxiaofei@huawei.com>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linuxarm@openeuler.org>
Subject: [PATCH v3 12/12] ACPI: dock: fix some coding style issues
Date: Sat, 27 Mar 2021 20:08:24 +0800 [thread overview]
Message-ID: <1616846904-25719-13-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1616846904-25719-1-git-send-email-tanxiaofei@huawei.com>
Fix some coding style issues reported by checkpatch.pl, including
following types:
WARNING: Missing a blank line after declarations
ERROR: spaces required around that ':'
WARNING: Statements should start on a tabstop
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/acpi/dock.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 0937cea..7cf9215 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -271,6 +271,7 @@ static void hotplug_dock_devices(struct dock_station *ds, u32 event)
if (!acpi_device_enumerated(adev)) {
int ret = acpi_bus_scan(adev->handle);
+
if (ret)
dev_dbg(&adev->dev, "scan error %d\n", -ret);
}
@@ -502,6 +503,7 @@ static ssize_t flags_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct dock_station *dock_station = dev->platform_data;
+
return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags);
}
@@ -523,7 +525,7 @@ static ssize_t undock_store(struct device *dev, struct device_attribute *attr,
begin_undock(dock_station);
ret = handle_eject_request(dock_station, ACPI_NOTIFY_EJECT_REQUEST);
acpi_scan_lock_release();
- return ret ? ret: count;
+ return ret ? ret : count;
}
static DEVICE_ATTR_WO(undock);
@@ -535,10 +537,11 @@ static ssize_t uid_show(struct device *dev,
{
unsigned long long lbuf;
struct dock_station *dock_station = dev->platform_data;
+
acpi_status status = acpi_evaluate_integer(dock_station->handle,
"_UID", NULL, &lbuf);
if (ACPI_FAILURE(status))
- return 0;
+ return 0;
return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf);
}
--
2.8.1
next prev parent reply other threads:[~2021-03-27 12:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 12:08 [PATCH v3 00/12] acpi: fix some coding style issues Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 01/12] ACPI: APD: fix a block comment align issue Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 02/12] ACPI: processor: fix some coding style issues Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 03/12] ACPI: ipmi: remove useless return statement for void function Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 04/12] ACPI: LPSS: add a missed blank line after declarations Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 05/12] ACPI: acpi_pad: " Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 06/12] ACPI: battery: fix some coding style issues Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 07/12] ACPI: button: " Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 08/12] ACPI: CPPC: " Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 09/12] ACPI: custom_method: fix a coding style issue Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 10/12] ACPI: PM: add a missed blank line after declarations Xiaofei Tan
2021-03-27 12:08 ` [PATCH v3 11/12] ACPI: sysfs: fix some coding style issues Xiaofei Tan
2021-03-27 12:08 ` Xiaofei Tan [this message]
2021-03-29 12:50 ` [PATCH v3 00/12] acpi: " Rafael J. Wysocki
2021-03-29 13:37 ` [Linuxarm] " Xiaofei Tan
2021-04-08 14:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616846904-25719-13-git-send-email-tanxiaofei@huawei.com \
--to=tanxiaofei@huawei.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).