From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Nipun Gupta <nipun.gupta@nxp.com>,
hch@lst.de, linux@armlinux.org.uk, gregkh@linuxfoundation.org,
m.szyprowski@samsung.com, bhelgaas@google.com,
dmitry.torokhov@gmail.com, rafael.j.wysocki@intel.com,
jarkko.sakkinen@linux.intel.com, linus.walleij@linaro.org,
johan@kernel.org, msuchanek@suse.de,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] dma-mapping: move dma configuration to bus infrastructure
Date: Wed, 14 Mar 2018 10:02:21 +0100 [thread overview]
Message-ID: <20180314090221.GE28983@lst.de> (raw)
In-Reply-To: <a6cd83c9-d769-2994-5230-0a97de1897e5@arm.com>
>> + .dev_groups = amba_dev_groups,
>> + .match = amba_match,
>> + .uevent = amba_uevent,
>> + .pm = &amba_pm,
>> + .dma_configure = amba_dma_configure,
>> + .dma_deconfigure = amba_dma_deconfigure,
>> + .force_dma = true,
>
> This patch should also be removing force_dma because it no longer makes
> sense. If DMA configuration is now done by a bus-level callback, then a bus
> which wants its children to get DMA configuration needs to implement that
> callback; there's nowhere to force a "default" global behaviour any more.
Btw, we don't really know how many busses currently rely on OF or ACPI
configuration. So maybe we need to keep those as a default?
next prev parent reply other threads:[~2018-03-14 9:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 15:24 [PATCH] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-12 16:44 ` Sinan Kaya
2018-03-13 4:22 ` Nipun Gupta
2018-03-13 7:27 ` hch
2018-03-13 7:34 ` Christoph Hellwig
2018-03-13 15:59 ` Nipun Gupta
2018-03-14 9:03 ` Christoph Hellwig
2018-03-13 11:35 ` Robin Murphy
2018-03-13 16:11 ` Nipun Gupta
2018-03-14 9:02 ` Christoph Hellwig [this message]
2018-03-13 21:53 ` kbuild test robot
2018-03-13 21:53 ` [RFC PATCH] dma-mapping: platform_dma_configure() can be static kbuild test robot
2018-03-14 5:48 ` [dma] 9a019f4251: BUG:unable_to_handle_kernel kernel test robot
2018-03-21 6:55 ` [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure Nipun Gupta
2018-03-21 6:55 ` [PATCH v2 2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-03-21 9:35 ` Greg KH
2018-03-21 16:28 ` Nipun Gupta
2018-03-21 17:49 ` Greg KH
2018-03-22 8:19 ` Christoph Hellwig
2018-03-22 15:13 ` Nipun Gupta
2018-03-23 16:09 ` kbuild test robot
2018-03-23 17:41 ` kbuild test robot
2018-03-21 7:19 ` [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure Bharat Bhushan
2018-03-21 7:29 ` Nipun Gupta
2018-03-22 8:17 ` hch
2018-03-21 9:29 ` Greg KH
2018-03-21 16:13 ` Nipun Gupta
2018-03-22 8:15 ` Christoph Hellwig
2018-03-22 15:05 ` Nipun Gupta
2018-03-24 9:25 ` kbuild test robot
2018-03-30 7:15 ` [PATCH] " Christoph Hellwig
2018-03-30 7:17 ` Nipun Gupta
2018-03-30 9:05 ` Greg KH
2018-03-30 7:54 ` [PATCH v3 1/2] " Nipun Gupta
2018-03-30 7:54 ` [PATCH v3 2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-04-09 20:27 ` Rob Herring
2018-04-10 19:21 ` Bjorn Helgaas
2018-04-10 19:20 ` [PATCH v3 1/2] dma-mapping: move dma configuration to bus infrastructure Bjorn Helgaas
2018-04-23 12:56 ` Christoph Hellwig
2018-04-23 12:56 ` Christoph Hellwig
2018-04-27 17:10 ` Nipun Gupta
2018-04-28 2:51 ` [PATCH v4 " Nipun Gupta
2018-04-28 2:51 ` [PATCH v4 2/2] drivers: remove force dma flag from buses Nipun Gupta
2018-05-01 12:34 ` Rob Herring
2018-05-03 16:36 ` Vinod Koul
2018-04-30 10:41 ` [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure Thierry Reding
2018-05-03 12:21 ` Christoph Hellwig
2018-05-03 12:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314090221.GE28983@lst.de \
--to=hch@lst.de \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=msuchanek@suse.de \
--cc=nipun.gupta@nxp.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).