Hi Nipun, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180323-232307 config: i386-randconfig-x013-201811 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/base/dma-mapping.c: In function 'dma_common_configure': >> drivers/base/dma-mapping.c:344:9: error: too many arguments to function 'of_dma_configure' ret = of_dma_configure(dev, dev->of_node, force_dma); ^~~~~~~~~~~~~~~~ In file included from drivers/base/dma-mapping.c:13:0: include/linux/of_device.h:110:19: note: declared here static inline int of_dma_configure(struct device *dev, struct device_node *np) ^~~~~~~~~~~~~~~~ -- drivers/pci/pci-driver.c: In function 'pci_dma_configure': >> drivers/pci/pci-driver.c:1544:9: error: too many arguments to function 'of_dma_configure' ret = of_dma_configure(dev, bridge->parent->of_node, true); ^~~~~~~~~~~~~~~~ In file included from drivers/pci/pci-driver.c:21:0: include/linux/of_device.h:110:19: note: declared here static inline int of_dma_configure(struct device *dev, struct device_node *np) ^~~~~~~~~~~~~~~~ vim +/of_dma_configure +344 drivers/base/dma-mapping.c 332 333 /* 334 * Common configuration to enable DMA API use for a device. 335 * A bus can use this function in its 'dma_configure' callback, if 336 * suitable for the bus. 337 */ 338 int dma_common_configure(struct device *dev, bool force_dma) 339 { 340 enum dev_dma_attr attr; 341 int ret = 0; 342 343 if (dev->of_node) { > 344 ret = of_dma_configure(dev, dev->of_node, force_dma); 345 } else if (has_acpi_companion(dev)) { 346 attr = acpi_get_dma_attr(to_acpi_device_node(dev->fwnode)); 347 if (attr != DEV_DMA_NOT_SUPPORTED) 348 ret = acpi_dma_configure(dev, attr); 349 } 350 351 return ret; 352 } 353 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation