Re: [PATCH v8 2/2] PCI: pciehp: Mask AER surprise link down error if hotplug is enabled

From: kbuild test robot <lkp@intel.com>
To: Sinan Kaya <okaya@kernel.org>
Cc: kbuild-all@01.org, linux-pci@vger.kernel.org,
	Sinan Kaya <okaya@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lukas Wunner <lukas@wunner.de>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 2/2] PCI: pciehp: Mask AER surprise link down error if hotplug is enabled
Date: Mon, 20 Aug 2018 08:20:22 +0800	[thread overview]
Message-ID: <201808200805.TsxYvRnY%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180818065126.77912-2-okaya@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

Hi Sinan,

I love your patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on next-20180817]
[cannot apply to v4.18]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sinan-Kaya/PCI-pciehp-Ignore-link-events-when-there-is-a-fatal-error-pending/20180820-074636
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: i386-randconfig-x075-201833 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/pci/hotplug/pciehp_core.c: In function 'pciehp_control_surprise_error':
>> drivers/pci/hotplug/pciehp_core.c:241:14: error: 'struct pci_dev' has no member named 'aer_cap'; did you mean 'ats_cap'?
     pos = pdev->aer_cap;
                 ^~~~~~~
                 ats_cap

vim +241 drivers/pci/hotplug/pciehp_core.c

   231	
   232	static int pciehp_control_surprise_error(struct controller *ctrl, bool enable)
   233	{
   234		struct pci_dev *pdev = ctrl->pcie->port;
   235		u32 reg32;
   236		int pos;
   237	
   238		if (!pci_is_pcie(pdev))
   239			return -ENODEV;
   240	
 > 241		pos = pdev->aer_cap;
   242		if (!pos)
   243			return -ENODEV;
   244	
   245		pci_read_config_dword(pdev, pos + PCI_ERR_UNCOR_MASK, &reg32);
   246		if (enable)
   247			reg32 &= ~PCI_ERR_UNC_SURPDN;
   248		else
   249			reg32 |= PCI_ERR_UNC_SURPDN;
   250		pci_write_config_dword(pdev, pos + PCI_ERR_UNCOR_MASK, reg32);
   251	
   252		return 0;
   253	}
   254	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32334 bytes --]