From: Keith Busch <keith.busch@intel.com>
To: Yanjiang Jin <yanjiang.jin@hxt-semitech.com>
Cc: bhelgaas@google.com, yu.zheng@hxt-semitech.com,
ruscur@russell.cc, sbobroff@linux.ibm.com, oohall@gmail.com,
jinyanjiang@gmail.com, linuxppc-dev@lists.ozlabs.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/AER: only insert one element into kfifo
Date: Wed, 12 Dec 2018 07:40:53 -0700 [thread overview]
Message-ID: <20181212144052.GA10780@localhost.localdomain> (raw)
In-Reply-To: <1544603550-14208-2-git-send-email-yanjiang.jin@hxt-semitech.com>
On Wed, Dec 12, 2018 at 04:32:30PM +0800, Yanjiang Jin wrote:
> 'commit ecae65e133f2 ("PCI/AER: Use kfifo_in_spinlocked() to
> insert locked elements")' replace kfifo_put() with kfifo_in_spinlocked().
>
> But as "kfifo_in(fifo, buf, n)" describes:
> " * @n: number of elements to be added".
>
> We want to insert only one element into kfifo, not "sizeof(entry) = 16".
> Without this patch, we would get 15 uninitialized elements.
>
> Signed-off-by: Yanjiang Jin <yanjiang.jin@hxt-semitech.com>
My bad. I had trouble testing the GHES path for this. Thanks for the fix.
Reviewed-by: Keith Busch <keith.busch@intel.com>
> ---
> drivers/pci/pcie/aer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index a90a919..fed29de 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -1064,7 +1064,7 @@ void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn,
> .regs = aer_regs,
> };
>
> - if (kfifo_in_spinlocked(&aer_recover_ring, &entry, sizeof(entry),
> + if (kfifo_in_spinlocked(&aer_recover_ring, &entry, 1,
> &aer_recover_ring_lock))
> schedule_work(&aer_recover_work);
> else
> --
> 1.8.3.1
next prev parent reply other threads:[~2018-12-12 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 8:32 [PATCH] Cover letter for (PCI/AER: only insert one element into kfifo) Yanjiang Jin
2018-12-12 8:32 ` [PATCH] PCI/AER: only insert one element into kfifo Yanjiang Jin
2018-12-12 14:40 ` Keith Busch [this message]
2018-12-14 17:36 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212144052.GA10780@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=jinyanjiang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=sbobroff@linux.ibm.com \
--cc=yanjiang.jin@hxt-semitech.com \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).