From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Ming Lei <ming.lei@redhat.com>,
linux-nvme@lists.infradead.org,
Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/4] nvme-pci: Set tagset nr_maps just once
Date: Fri, 4 Jan 2019 19:15:28 +0100 [thread overview]
Message-ID: <20190104181528.GA25651@lst.de> (raw)
In-Reply-To: <20190103210954.11129-1-keith.busch@intel.com>
On Thu, Jan 03, 2019 at 02:09:51PM -0700, Keith Busch wrote:
> The driver overwrites the intermediate nr_map assignments to
> HCTX_MAX_TYPES, so remove those unnecessary temporary settings.
>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
Actually the more complex calculation is the right one here.
I've just merged a patch from Jianchao to remove the other line.
next prev parent reply other threads:[~2019-01-04 18:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 21:09 [PATCH 1/4] nvme-pci: Set tagset nr_maps just once Keith Busch
2019-01-03 21:09 ` [PATCH 2/4] nvme-pci: Distribute io queue types after creation Keith Busch
2019-01-03 21:09 ` [PATCH 3/4] pci/irq: Handle vector reduce and retry Keith Busch
2019-01-03 21:39 ` Bjorn Helgaas
2019-01-03 21:51 ` Keith Busch
2019-01-03 21:09 ` [PATCH 4/4] nvme-pci: Use PCI to handle IRQ " Keith Busch
2019-01-04 18:15 ` Christoph Hellwig [this message]
2019-01-04 18:19 ` [PATCH 1/4] nvme-pci: Set tagset nr_maps just once Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104181528.GA25651@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).