From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Wen Yang <wen.yang99@zte.com.cn>, Kishon Vijay Abraham I <kishon@ti.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
zhong.weidong@zte.com.cn,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Niklas Cassel <niklas.cassel@axis.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cyrille Pitchen <cyrille.pitchen@free-electrons.com>
Subject: Re: [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function
Date: Fri, 8 Feb 2019 12:20:27 +0000 [thread overview]
Message-ID: <20190208122027.GE13009@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20181206125225.9497-1-wen.yang99@zte.com.cn>
On Thu, Dec 06, 2018 at 08:52:25PM +0800, Wen Yang wrote:
> kmemdup has implemented the function that kmalloc() + memcpy().
> We prefer to kmemdup rather than code opened implementation.
>
> This issue was detected with the help of coccinelle.
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> CC: Kishon Vijay Abraham I <kishon@ti.com>
> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> CC: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> CC: Niklas Cassel <niklas.cassel@axis.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Cyrille Pitchen <cyrille.pitchen@free-electrons.com>
> CC: linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
> CC: linux-kernel@vger.kernel.org (open list)
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Kishon,
this looks OK to me, anything I am missing ?
Lorenzo
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 3e86fa3c7da3..8df6c019f8a2 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -169,14 +169,12 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test)
> goto err_addr;
> }
>
> - buf = kzalloc(reg->size, GFP_KERNEL);
> + buf = kmemdup(src_addr, reg->size, GFP_KERNEL);
> if (!buf) {
> ret = -ENOMEM;
> goto err_map_addr;
> }
>
> - memcpy(buf, src_addr, reg->size);
> -
> crc32 = crc32_le(~0, buf, reg->size);
> if (crc32 != reg->checksum)
> ret = -EIO;
> --
> 2.19.1
>
next prev parent reply other threads:[~2019-02-08 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 12:52 [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of duplicating its function Wen Yang
2019-02-08 12:20 ` Lorenzo Pieralisi [this message]
2019-02-11 5:48 ` Kishon Vijay Abraham I
2019-02-11 9:15 ` Gustavo Pimentel
2019-02-11 12:37 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208122027.GE13009@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=cyrille.pitchen@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=wen.yang99@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).