From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Joao Pinto <joao.pinto@synopsys.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: dwc: Print debug error message when MSI-X entry control mask bit is set
Date: Fri, 8 Feb 2019 12:25:53 +0000 [thread overview]
Message-ID: <20190208122553.GF13009@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <a5f26b59ae720edf4f3b90e4ee2d052e2920dca9.1544203477.git.gustavo.pimentel@synopsys.com>
On Fri, Dec 07, 2018 at 06:24:37PM +0100, Gustavo Pimentel wrote:
> Add debug error message when MSI-X entry control mask bit is set, to help
> debug the reason why a MSI-X interrupt is not being triggered.
>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Joao Pinto <joao.pinto@synopsys.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to pci/dwc for v5.1, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 1e7b022..a969322 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -466,8 +466,10 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no,
>
> iounmap(msix_tbl);
>
> - if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT)
> + if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT) {
> + dev_dbg(pci->dev, "MSI-X entry ctrl set\n");
> return -EPERM;
> + }
>
> ret = dw_pcie_ep_map_addr(epc, func_no, ep->msi_mem_phys, msg_addr,
> epc->mem->page_size);
> --
> 2.7.4
>
prev parent reply other threads:[~2019-02-08 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 17:24 [PATCH v2] PCI: dwc: Print debug error message when MSI-X entry control mask bit is set Gustavo Pimentel
2019-02-08 12:25 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208122553.GF13009@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=joao.pinto@synopsys.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).