From: Bjorn Helgaas <helgaas@kernel.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Marc Zyngier <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] genirq/msi: Clean up usage of __u8/__u16 types
Date: Fri, 8 Feb 2019 13:44:45 -0600 [thread overview]
Message-ID: <20190208194444.GW7268@google.com> (raw)
In-Reply-To: <20190208165439.19503-1-logang@deltatee.com>
[+cc Marc, Thomas]
On Fri, Feb 08, 2019 at 09:54:38AM -0700, Logan Gunthorpe wrote:
> The double underscore types are meant for compatibility in userspace
> headers which does not apply here. Therefore, change to use the
> standard no-underscore types.
>
> The origin of the double underscore types dates back to before the
> git era so I was not able to find a commit to see the original
> justification.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Cc: Bjorn Helgaas <helgaas@kernel.org>
I applied both of these:
PCI: Clean up usage of __u32 type
genirq/msi: Clean up usage of __u8/__u16 types
to pci/misc for v5.1, thanks!
> ---
> include/linux/msi.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/msi.h b/include/linux/msi.h
> index 784fb52b9900..7e9b81c3b50d 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -83,12 +83,12 @@ struct msi_desc {
> struct {
> u32 masked;
> struct {
> - __u8 is_msix : 1;
> - __u8 multiple : 3;
> - __u8 multi_cap : 3;
> - __u8 maskbit : 1;
> - __u8 is_64 : 1;
> - __u16 entry_nr;
> + u8 is_msix : 1;
> + u8 multiple : 3;
> + u8 multi_cap : 3;
> + u8 maskbit : 1;
> + u8 is_64 : 1;
> + u16 entry_nr;
> unsigned default_irq;
> } msi_attrib;
> union {
> --
> 2.19.0
>
prev parent reply other threads:[~2019-02-08 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 16:54 [PATCH 1/2] genirq/msi: Clean up usage of __u8/__u16 types Logan Gunthorpe
2019-02-08 16:54 ` [PATCH 2/2] PCI: Clean up usage of __u32 type Logan Gunthorpe
2019-02-08 19:44 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208194444.GW7268@google.com \
--to=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).