From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Trent Piepho <tpiepho@impinj.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>
Subject: Re: [PATCH v2 3/3] PCI: imx: Add workaround for e10728, IMX7d PCIe PLL failure
Date: Mon, 11 Feb 2019 12:18:04 +0000 [thread overview]
Message-ID: <20190211121804.GA19106@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <1549649949.3075.79.camel@impinj.com>
On Fri, Feb 08, 2019 at 06:19:10PM +0000, Trent Piepho wrote:
> On Fri, 2019-02-08 at 10:18 +0000, Lorenzo Pieralisi wrote:
> > On Thu, Feb 07, 2019 at 06:15:52PM +0000, Trent Piepho wrote:
> > > On Thu, 2019-02-07 at 12:31 +0000, Lorenzo Pieralisi wrote:
> > > > + /* De-assert DCC_FB_EN */
> > > > > + writel(PCIE_PHY_CMN_REG4_DCC_FB_EN,
> > > > > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG4);
> > > > > + /* Assert RX_EQS and RX_EQS_SEL */
> > > > > + writel(PCIE_PHY_CMN_REG24_RX_EQ_SEL
> > > > > + | PCIE_PHY_CMN_REG24_RX_EQ,
> > > > > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG24);
> > > > > + /* Assert ATT_MODE */
> > > > > + writel(PCIE_PHY_CMN_REG26_ATT_MODE,
> > > > > + imx6_pcie->phy_base + PCIE_PHY_CMN_REG26);
> > > > > + } else {
> > > > > + dev_warn(dev, "DT lacks imx7d-pcie-phy, unable to apply ERR010728 workaround\n");
> > > >
> > > > It is a nit but the warning log is not necessarily true ie you may not
> > > > have a mapped address for other reasons as well. It is up to you but I
> > > > would change the log message.
> > >
> > > True, but I hardly want to enumerate every possible failure point in a
> > > log message. How about:
> > >
> > > Unable to apply ERR010728 workaround. DT lacks imx7d-pcie-phy?
> >
> > I would just log "Unable to apply ERR010728 workaround" but it is up
> > to you. I can make the change myself with no need for reposting.
>
> I was following Lucas's comment on the v1 version:
>
> the user. It would be better to have something like "No access to
> PHY registers, can't apply workaround for ERR010728." Maybe even
> with a hint to update the DT.
>
> I think the pretty much the only way any of the errors conditions will
> get hit, is when someone with an old DT runs a new kernel. So the hint
> about the DT change might be actually useful to some users.
>
> But it's not a big deal so just change it to whatever when applying the
> patch.
Applied the series to pci/dwc for v5.1, please have a look to check
if we are in agreement (slightly tweaked the log string), thanks.
Lorenzo
prev parent reply other threads:[~2019-02-11 12:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 0:17 [PATCH v2 0/3] Workaround for IMX7d PCI-e PLL lock failure Trent Piepho
2019-02-05 0:17 ` [PATCH v2 1/3] dt-bindings: imx6q-pcie: Add description of imx7d pcie phy Trent Piepho
2019-02-05 9:43 ` Lucas Stach
2019-02-05 0:17 ` [PATCH v2 2/3] ARM: dts: imx7d: Add node for PCIe PHY Trent Piepho
2019-02-05 9:47 ` Lucas Stach
2019-02-05 0:17 ` [PATCH v2 3/3] PCI: imx: Add workaround for e10728, IMX7d PCIe PLL failure Trent Piepho
2019-02-05 9:48 ` Lucas Stach
2019-02-07 12:31 ` Lorenzo Pieralisi
2019-02-07 18:15 ` Trent Piepho
2019-02-08 10:18 ` Lorenzo Pieralisi
2019-02-08 18:19 ` Trent Piepho
2019-02-11 12:18 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211121804.GA19106@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=hongxing.zhu@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).