From: Guenter Roeck <linux@roeck-us.net>
To: John Garry <john.garry@huawei.com>
Cc: jdelvare@suse.com, bhelgaas@google.com, rafael@kernel.org,
arnd@arndb.de, lorenzo.pieralisi@arm.com, bp@suse.de,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, wangkefeng.wang@huawei.com,
linuxarm@huawei.com
Subject: Re: [RFC PATCH 2/2] hwmon: (f71805f): Use request_region() in f71805f_init()
Date: Thu, 14 Mar 2019 10:05:34 -0700 [thread overview]
Message-ID: <20190314170534.GB14159@roeck-us.net> (raw)
In-Reply-To: <1552582516-70855-3-git-send-email-john.garry@huawei.com>
On Fri, Mar 15, 2019 at 12:55:16AM +0800, John Garry wrote:
> Currently the driver does not call request_region() prior to
> accessing IO port regions in f71805f_init(), so add it.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> drivers/hwmon/f71805f.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c
> index 73c681162653..910082c7f184 100644
> --- a/drivers/hwmon/f71805f.c
> +++ b/drivers/hwmon/f71805f.c
> @@ -1617,10 +1617,21 @@ static int __init f71805f_init(void)
> int err;
> unsigned short address;
> struct f71805f_sio_data sio_data;
> + struct resource *res;
> + size_t size = 0x4e - 0x2e + SIO_REG_ADDR + 4;
> +
> + /* Request the whole 0x2e - 0x4e region */
> + res = request_region(0x2e, size, "f71805f");
request_muxed_region() would be a better choice here since it doesn't
bail out immediately if the region is temporarily busy.
Thanks,
Guenter
> + if (!res)
> + return -EBUSY;
>
> if (f71805f_find(0x2e, &address, &sio_data)
> - && f71805f_find(0x4e, &address, &sio_data))
> + && f71805f_find(0x4e, &address, &sio_data)) {
> + release_region(0x2e, size);
> return -ENODEV;
> + }
> +
> + release_region(0x2e, size);
>
> err = platform_driver_register(&f71805f_driver);
> if (err)
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-03-14 17:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 16:55 [RFC PATCH 0/2] Fix system crash for accessing unmapped IO port regions John Garry
2019-03-14 16:55 ` [RFC PATCH 1/2] resource: Request IO port regions from children of ioport_resource John Garry
2019-03-14 17:12 ` Guenter Roeck
2019-03-14 17:39 ` John Garry
2019-03-14 16:55 ` [RFC PATCH 2/2] hwmon: (f71805f): Use request_region() in f71805f_init() John Garry
2019-03-14 17:05 ` Guenter Roeck [this message]
2019-03-14 17:21 ` John Garry
2019-03-14 17:44 ` Guenter Roeck
2019-03-15 11:20 ` John Garry
2019-03-15 12:58 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314170534.GB14159@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=jdelvare@suse.com \
--cc=john.garry@huawei.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=rafael@kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).