From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: bhelgaas@google.com, nic_swsd@realtek.com,
linux-pci@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] PCI: let pci_disable_link_state propagate errors
Date: Wed, 19 Jun 2019 17:26:39 -0400 (EDT) [thread overview]
Message-ID: <20190619.172639.2296773807837656357.davem@davemloft.net> (raw)
In-Reply-To: <5ea56278-05e2-794f-5f66-23343e72164c@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 18 Jun 2019 23:12:56 +0200
> Drivers like r8169 rely on pci_disable_link_state() having disabled
> certain ASPM link states. If OS can't control ASPM then
> pci_disable_link_state() turns into a no-op w/o informing the caller.
> The driver therefore may falsely assume the respective ASPM link
> states are disabled. Let pci_disable_link_state() propagate errors
> to the caller, enabling the caller to react accordingly.
>
> I'd propose to let this series go through the netdev tree if the PCI
> core extension is acked by the PCI people.
Bjorn et al., please look at patch #1 and ACK/NACK
Thank you.
next prev parent reply other threads:[~2019-06-19 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 21:12 [PATCH net-next 0/2] PCI: let pci_disable_link_state propagate errors Heiner Kallweit
2019-06-18 21:13 ` [PATCH net-next 1/2] " Heiner Kallweit
2019-06-19 21:32 ` Bjorn Helgaas
2019-06-18 21:14 ` [PATCH net-next 2/2] r8169: don't activate ASPM in chip if OS can't control ASPM Heiner Kallweit
2019-06-19 21:26 ` David Miller [this message]
2019-06-22 2:06 ` [PATCH net-next 0/2] PCI: let pci_disable_link_state propagate errors David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619.172639.2296773807837656357.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).