From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB87C48BD9 for ; Thu, 27 Jun 2019 17:01:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BECE620659 for ; Thu, 27 Jun 2019 17:01:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726482AbfF0RBv (ORCPT ); Thu, 27 Jun 2019 13:01:51 -0400 Received: from verein.lst.de ([213.95.11.210]:40324 "EHLO newverein.lst.de" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726405AbfF0RBv (ORCPT ); Thu, 27 Jun 2019 13:01:51 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id D884D68C7B; Thu, 27 Jun 2019 18:54:28 +0200 (CEST) Date: Thu, 27 Jun 2019 18:54:28 +0200 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Ben Skeggs , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-nvdimm@lists.01.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , John Hubbard , Michal Hocko Subject: Re: [PATCH 03/25] mm: remove hmm_devmem_add_resource Message-ID: <20190627165428.GC10652@lst.de> References: <20190626122724.13313-1-hch@lst.de> <20190626122724.13313-4-hch@lst.de> <20190627161813.GB9499@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627161813.GB9499@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jun 27, 2019 at 04:18:22PM +0000, Jason Gunthorpe wrote: > On Wed, Jun 26, 2019 at 02:27:02PM +0200, Christoph Hellwig wrote: > > This function has never been used since it was first added to the kernel > > more than a year and a half ago, and if we ever grow a consumer of the > > MEMORY_DEVICE_PUBLIC infrastructure it can easily use devm_memremap_pages > > directly. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Jason Gunthorpe > > Reviewed-by: John Hubbard > > Acked-by: Michal Hocko > > --- > > include/linux/hmm.h | 3 --- > > mm/hmm.c | 50 --------------------------------------------- > > 2 files changed, 53 deletions(-) > > This should be squashed to the new earlier patch? We could do that. Do you just want to do that when you apply it?