From: Bjorn Helgaas <helgaas@kernel.org>
To: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
Date: Tue, 23 Jul 2019 18:36:51 -0500 [thread overview]
Message-ID: <20190723233651.GD47047@google.com> (raw)
In-Reply-To: <20190717182353.45557-1-skunberg.kelsey@gmail.com>
[+cc Greg]
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Applied with Greg's ack to pci/hide for v5.4, thanks!
> ---
> drivers/pci/bus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index 495059d923f7..8e40b3e6da77 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
> get_device(&bus->dev);
> return bus;
> }
> -EXPORT_SYMBOL(pci_bus_get);
>
> void pci_bus_put(struct pci_bus *bus)
> {
> if (bus)
> put_device(&bus->dev);
> }
> -EXPORT_SYMBOL(pci_bus_put);
> --
> 2.20.1
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2019-07-23 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 18:23 [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c Kelsey Skunberg
2019-07-17 20:48 ` [Linux-kernel-mentees] " Greg KH
2019-07-23 23:36 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723233651.GD47047@google.com \
--to=helgaas@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=skunberg.kelsey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).