From: Bjorn Helgaas <helgaas@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [RFC/PATCH] PCI: Protect pci_reassign_bridge_resources() against concurrent addition/removal
Date: Mon, 23 Sep 2019 16:50:27 -0500 [thread overview]
Message-ID: <20190923215027.GA11938@google.com> (raw)
In-Reply-To: <20190821130827.GF14450@google.com>
On Wed, Aug 21, 2019 at 08:08:27AM -0500, Bjorn Helgaas wrote:
> On Mon, Jun 24, 2019 at 02:32:19PM +1000, Benjamin Herrenschmidt wrote:
> > pci_reassign_bridge_resources() can be called by pci_resize_resource()
> > at runtime.
> >
> > It will walk the PCI tree up and down, and isn't currently protected
> > against any changes or hotplug operation.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Applied to pci/resource for v5.4, thanks!
Dropped for now per Dan's bug report:
https://lore.kernel.org/r/20190904100303.GD7007@mwanda
> > ---
> >
> > --- a/drivers/pci/setup-bus.c
> > +++ b/drivers/pci/setup-bus.c
> > @@ -2104,6 +2104,8 @@ int pci_reassign_bridge_resources(struct pci_dev *bridge, unsigned long type)
> > unsigned int i;
> > int ret;
> >
> > + down_read(&pci_bus_sem);
> > +
> > /* Walk to the root hub, releasing bridge BARs when possible */
> > next = bridge;
> > do {
> > @@ -2160,6 +2162,7 @@ int pci_reassign_bridge_resources(struct pci_dev *bridge, unsigned long type)
> > }
> >
> > free_list(&saved);
> > + up_read(&pci_bus_sem);
> > return 0;
> >
> > cleanup:
> > @@ -2188,6 +2191,7 @@ int pci_reassign_bridge_resources(struct pci_dev *bridge, unsigned long type)
> > pci_setup_bridge(bridge->subordinate);
> > }
> > free_list(&saved);
> > + up_read(&pci_bus_sem);
> >
> > return ret;
> > }
> >
prev parent reply other threads:[~2019-09-23 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 4:32 [RFC/PATCH] PCI: Protect pci_reassign_bridge_resources() against concurrent addition/removal Benjamin Herrenschmidt
2019-08-21 13:08 ` Bjorn Helgaas
2019-09-23 21:50 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923215027.GA11938@google.com \
--to=helgaas@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).