From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: Sinan Kaya <okaya@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
bhelgaas@google.com, Thierry Reding <treding@nvidia.com>,
jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
linux-pci@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH] PCI: Add CRS timeout for pci_device_is_present()
Date: Mon, 4 Nov 2019 16:52:55 +0000 [thread overview]
Message-ID: <20191104165255.GA26409@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <065d1b8a-29e1-9282-27ba-5512f9f4f1d4@nvidia.com>
On Mon, Nov 04, 2019 at 05:13:50PM +0530, Vidya Sagar wrote:
> On 10/26/2019 7:29 PM, Sinan Kaya wrote:
> > On 10/25/2019 7:58 AM, Vidya Sagar wrote:
> > > On 10/21/2019 11:13 AM, Vidya Sagar wrote:
> > >
> > > Hi Sinan / Rafael,
> > > Apologies for the ping again.
> > > Do you guys have any further comments on this?
> > >
> > > -Vidya Sagar
> >
> > I think you'll need some attention from Bjorn here to see the complete
> > picture.
> >
> > As I said, changing pci_device_is_present() is not right. This needs to
> > be done at one level higher.
>
> Hi Bjorn,
> Could you please help me understand why this change can't be done in
> pci_device_is_present() API?
I assume that's because pci_device_is_present() is currently called
in contexts that aren't allowed to sleep, therefore you would trigger
a regression.
Lorenzo
next prev parent reply other threads:[~2019-11-04 16:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 18:21 [PATCH] PCI: Add CRS timeout for pci_device_is_present() Vidya Sagar
2019-10-14 8:20 ` Thierry Reding
2019-10-14 20:21 ` Sinan Kaya
2019-10-15 9:30 ` Thierry Reding
2019-10-15 11:10 ` Sinan Kaya
2019-10-15 12:14 ` Vidya Sagar
[not found] ` <afa16546-e63d-6eba-8be0-8e52339cd100@nvidia.com>
2019-10-25 11:58 ` Vidya Sagar
2019-10-26 13:59 ` Sinan Kaya
2019-11-04 11:43 ` Vidya Sagar
2019-11-04 16:52 ` Lorenzo Pieralisi [this message]
2019-11-04 17:39 ` Bjorn Helgaas
2019-11-05 10:55 ` Rafael J. Wysocki
2019-11-06 16:41 ` Bjorn Helgaas
2019-11-11 6:01 ` Vidya Sagar
2019-11-11 22:32 ` Bjorn Helgaas
2019-11-12 12:59 ` Thierry Reding
2019-11-12 14:21 ` Bjorn Helgaas
2019-11-12 17:59 ` Vidya Sagar
2019-11-12 18:58 ` Bjorn Helgaas
2019-11-13 5:39 ` Vidya Sagar
2019-11-13 11:20 ` Thierry Reding
2019-11-14 18:36 ` Bjorn Helgaas
2019-11-15 10:04 ` Vidya Sagar
2019-11-15 22:36 ` Bjorn Helgaas
2019-11-18 15:18 ` Vidya Sagar
2019-11-12 17:59 ` Vidya Sagar
2019-10-15 12:03 ` Vidya Sagar
2019-10-15 11:34 ` Vidya Sagar
2019-10-14 10:45 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104165255.GA26409@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=okaya@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).