linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Murray <andrew.murray@arm.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Stanimir Varbanov <svarbanov@mm-sol.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: qcom: Add support for SDM845 PCIe
Date: Mon, 16 Dec 2019 10:32:29 +0000	[thread overview]
Message-ID: <20191216103229.GP24359@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191107001642.1127561-2-bjorn.andersson@linaro.org>

On Wed, Nov 06, 2019 at 04:16:41PM -0800, Bjorn Andersson wrote:
> Add compatible and necessary clocks and resets definitions for the
> SDM845 PCIe controller.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---

Reviewed-by: Andrew Murray <andrew.murray@arm.com>

> 
> Changes since v1:
> - Picked up Rob and Vinod's R-b
> 
>  .../devicetree/bindings/pci/qcom,pcie.txt     | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> index ada80b01bf0c..981b4de12807 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> @@ -11,6 +11,7 @@
>  			- "qcom,pcie-ipq4019" for ipq4019
>  			- "qcom,pcie-ipq8074" for ipq8074
>  			- "qcom,pcie-qcs404" for qcs404
> +			- "qcom,pcie-sdm845" for sdm845
>  
>  - reg:
>  	Usage: required
> @@ -126,6 +127,18 @@
>  			- "master_bus"	AXI Master clock
>  			- "slave_bus"	AXI Slave clock
>  
> +-clock-names:
> +	Usage: required for sdm845
> +	Value type: <stringlist>
> +	Definition: Should contain the following entries
> +			- "aux"		Auxiliary clock
> +			- "cfg"		Configuration clock
> +			- "bus_master"	Master AXI clock
> +			- "bus_slave"	Slave AXI clock
> +			- "slave_q2a"	Slave Q2A clock
> +			- "tbu"		PCIe TBU clock
> +			- "pipe"	PIPE clock
> +
>  - resets:
>  	Usage: required
>  	Value type: <prop-encoded-array>
> @@ -188,6 +201,12 @@
>  			- "pwr"			PWR reset
>  			- "ahb"			AHB reset
>  
> +- reset-names:
> +	Usage: required for sdm845
> +	Value type: <stringlist>
> +	Definition: Should contain the following entries
> +			- "pci"			PCIe core reset
> +
>  - power-domains:
>  	Usage: required for apq8084 and msm8996/apq8096
>  	Value type: <prop-encoded-array>
> -- 
> 2.23.0
> 

  reply	other threads:[~2019-12-16 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  0:16 [PATCH v3 0/2] PCI: qcom: Add support for SDM845 PCIe Bjorn Andersson
2019-11-07  0:16 ` [PATCH v3 1/2] dt-bindings: " Bjorn Andersson
2019-12-16 10:32   ` Andrew Murray [this message]
2019-11-07  0:16 ` [PATCH v3 2/2] PCI: qcom: Add support for SDM845 PCIe controller Bjorn Andersson
2019-11-07 13:38   ` Philipp Zabel
2019-11-13 12:47   ` Stanimir Varbanov
2019-12-13 12:02   ` Andrew Murray
2019-12-27  8:45   ` Stanimir Varbanov
2020-01-02 12:02   ` Philipp Zabel
2019-11-07 15:21 ` [PATCH v3 0/2] PCI: qcom: Add support for SDM845 PCIe Julien Massot
2019-12-27  1:23 ` Bjorn Andersson
2020-01-10 16:55   ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216103229.GP24359@e119886-lin.cambridge.arm.com \
    --to=andrew.murray@arm.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=svarbanov@mm-sol.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).