linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: linux-pci@vger.kernel.org, f.fangjian@huawei.com, huangdaode@huawei.com
Subject: Re: [PATCH 0/2] PCI: Fix potential deadlock problems
Date: Wed, 5 Feb 2020 11:30:02 -0600	[thread overview]
Message-ID: <20200205173002.GA221036@google.com> (raw)
In-Reply-To: <1580894277-20671-1-git-send-email-yangyicong@hisilicon.com>

On Wed, Feb 05, 2020 at 05:17:57PM +0800, Yicong Yang wrote:
> Currently we use several locks to avoid racing conditions in pci
> framework. When involving more than one lock, the inconsistent
> lock order will lead to deadlock problems. This patchset aims to
> solve the problem by keeping the same lock order in different
> processes.
> 
> Patch_1: fix the potential deadlock caused by pci_dev_lock() and
> VF enable routine.
> Patch_2: fix the deadlock caused by AER and sriov enable routine
> as reported.

If it's possible for you to send these with the patches as responses
to the cover letter (as you did for the Jan 15 link speed patches),
the tools will work better, e.g., patchwork will notice that they all
belong together.

No need to resend this series for that reason, just FYI for the
future.

> Yicong Yang (2):
>   PCI: Change lock order in pci_dev_lock()
>   PCI/AER: Fix deadlock triggered by AER and sriov enable routine
> 
>  drivers/pci/bus.c      |  8 ++++++++
>  drivers/pci/pci.c      | 15 ++++++++-------
>  drivers/pci/pci.h      |  4 ++++
>  drivers/pci/pcie/err.c | 18 +++++-------------
>  4 files changed, 25 insertions(+), 20 deletions(-)
> 
> --
> 2.8.1
> 

      reply	other threads:[~2020-02-05 17:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05  9:17 [PATCH 0/2] PCI: Fix potential deadlock problems Yicong Yang
2020-02-05 17:30 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205173002.GA221036@google.com \
    --to=helgaas@kernel.org \
    --cc=f.fangjian@huawei.com \
    --cc=huangdaode@huawei.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).