From: Bjorn Helgaas <helgaas@kernel.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Kishon Vijay Abraham I <kishon@ti.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Jingoo Han <jingoohan1@gmail.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Tom Joseph <tjoseph@cadence.com>,
Heiko Stuebner <heiko@sntech.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
linux-rockchip@lists.infradead.org,
Lad Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH v7 6/8] PCI: rcar: Add support for R-Car PCIe controller in endpoint mode
Date: Wed, 8 Apr 2020 18:51:33 -0500 [thread overview]
Message-ID: <20200408235133.GA151858@google.com> (raw)
In-Reply-To: <1586360280-10956-7-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
Maybe:
PCI: rcar: Add endpoint mode support
so the important "endpoint mode" part is early and doesn't get chopped
off or wrapped. We already know it's PCIe and rcar-related.
On Wed, Apr 08, 2020 at 04:37:58PM +0100, Lad Prabhakar wrote:
> This patch adds support for R-Car PCIe controller to work in endpoint mode.
s/This patch adds/Add/
> +static int rcar_pcie_ep_set_bar(struct pci_epc *epc, u8 func_no,
> + struct pci_epf_bar *epf_bar)
> +{
> + int flags = epf_bar->flags | LAR_ENABLE | LAM_64BIT;
> + struct rcar_pcie_endpoint *ep = epc_get_drvdata(epc);
> + u64 size = 1ULL << fls64(epf_bar->size - 1);
> + dma_addr_t cpu_addr = epf_bar->phys_addr;
> + enum pci_barno bar = epf_bar->barno;
> + struct rcar_pcie *pcie = &ep->pcie;
> + u32 mask;
> + int idx;
> + int err;
> +
> + idx = find_first_zero_bit(ep->ib_window_map, ep->num_ib_windows);
> + if (idx >= ep->num_ib_windows) {
> + dev_err(pcie->dev, "no free inbound window\n");
> + return -EINVAL;
> + }
> +
> + if ((flags & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO)
> + flags |= IO_SPACE;
> +
> + ep->bar_to_atu[bar] = idx;
> + /* use 64 bit bars */
s/64 bit bars/64-bit BARs/
> +static const struct pci_epc_features rcar_pcie_epc_features = {
> + .linkup_notifier = false,
> + .msi_capable = true,
> + .msix_capable = false,
> + /* use 64-bit bars so mark bar1/3/5 as reserved */
s/bar/BAR/g
next prev parent reply other threads:[~2020-04-08 23:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 15:37 [PATCH v7 0/8] Add support for PCIe controller to work in endpoint mode on R-Car/RZ/G2x SoCs Lad Prabhakar
2020-04-08 15:37 ` [PATCH v7 1/8] PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c Lad Prabhakar
2020-04-08 15:37 ` [PATCH v7 2/8] PCI: rcar: Move shareable code to a common file Lad Prabhakar
2020-04-08 23:30 ` Bjorn Helgaas
2020-04-09 10:06 ` Lad, Prabhakar
2020-04-08 15:37 ` [PATCH v7 3/8] PCI: rcar: Fix calculating mask for PCIEPAMR register Lad Prabhakar
2020-04-08 15:37 ` [PATCH v7 4/8] PCI: endpoint: Add support to handle multiple base for mapping outbound memory Lad Prabhakar
2020-04-08 23:46 ` Bjorn Helgaas
2020-04-09 10:12 ` Lad, Prabhakar
2020-04-08 15:37 ` [PATCH v7 5/8] dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller Lad Prabhakar
2020-04-08 15:37 ` [PATCH v7 6/8] PCI: rcar: Add support for R-Car PCIe controller in endpoint mode Lad Prabhakar
2020-04-08 23:51 ` Bjorn Helgaas [this message]
2020-04-09 10:14 ` Lad, Prabhakar
2020-04-08 15:37 ` [PATCH v7 7/8] PCI: Add Renesas R8A774C0 device ID Lad Prabhakar
2020-04-08 23:53 ` Bjorn Helgaas
2020-04-09 9:36 ` Sergei Shtylyov
2020-04-09 10:04 ` Lad, Prabhakar
2020-04-10 0:12 ` Yoshihiro Shimoda
2020-04-08 15:38 ` [PATCH v7 8/8] MAINTAINERS: Add file patterns for rcar PCI device tree bindings Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408235133.GA151858@google.com \
--to=helgaas@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gustavo.pimentel@synopsys.com \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tjoseph@cadence.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).