From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7962C433E0 for ; Wed, 24 Jun 2020 23:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C142C207E8 for ; Wed, 24 Jun 2020 23:37:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ghe0LNHZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388031AbgFXXhh (ORCPT ); Wed, 24 Jun 2020 19:37:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387843AbgFXXhc (ORCPT ); Wed, 24 Jun 2020 19:37:32 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79453C0613ED for ; Wed, 24 Jun 2020 16:37:31 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id s14so1852784plq.6 for ; Wed, 24 Jun 2020 16:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mo7Dwe07kJhP63QLmOzciNFvW218NBaVIlEPp4HbWlg=; b=ghe0LNHZStIXrutzWngNn1w8HnVKxzkKAANg+f3UNbpWa1VXDLTQLRRUxQiw0ETxf1 8IwO0ripMH+IKCR86WNY+ysG11jZ8MVO51xum9mEa475UtB+fdRpajYIKrof1LeRnhfw q/KZy9ALnBT7rcr/zSWyqYTnZ3OeY5pBxENZEDhKneGeIxS3jxNDb3T6z60V1Qc+Vdy6 OTaykXWX6WKsBL92+Zu8AYSrqkunkoROSncALDdIHd5jRSMEYzkTx2v4nRNz4Z77j4S9 tRCzT7qVWnXl4XZ9bSsfQVqiYUdUQyfJWFL+rlMfK7ACBBFVz6umkgQZxUMxIfkAgDuf rFfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mo7Dwe07kJhP63QLmOzciNFvW218NBaVIlEPp4HbWlg=; b=EW+tMd3SJjoxsae9h2nhRFRDG60Nis6fmHX95AT3lg3qZn26eK+Ow74EGMlLP8QYzW rX1aFt/aVBSKPuvLUXl+BJ87aSb59iWNcN10spb6ObP2GTCKkQp1t4oY3Di2MwC3rHeD lJrNW7J/IU6WDgOU5/PATNWkrlygiCX7vHToOxDj1fh4X8C6Zqax86PIDWHOnRIStM12 qfGA5K7Djg+UAi3pCYC4rYEuXbbUkPmXmJeJfe5B1WofpAXmZQ1/X954gH+1GR+zm3r2 Ci38lbPWpjtXiHor5c4u2qyfzmkSTq5VychDT1LmlYcpCwSDq4nB0XHKti1apmuG5hfC 2IJw== X-Gm-Message-State: AOAM531gxvRXYlEYhRGnmxZG1QFpPAITMUDd33g+xgAiVl4kzOBLUrI1 OxRrowNtyoMm9qrs4/WmrYkx7w== X-Google-Smtp-Source: ABdhPJzbL+A8YRu6cQqMhEnH4JVMHPuZevDUkJdMyUg1rfNtOurVArWJG2BoYxI9g7/QXZLvtzZHnQ== X-Received: by 2002:a17:90a:9d8b:: with SMTP id k11mr267919pjp.10.1593041850610; Wed, 24 Jun 2020 16:37:30 -0700 (PDT) Received: from google.com ([2620:15c:201:2:ce90:ab18:83b0:619]) by smtp.gmail.com with ESMTPSA id c9sm21338811pfr.72.2020.06.24.16.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 16:37:29 -0700 (PDT) Date: Wed, 24 Jun 2020 16:37:24 -0700 From: Sami Tolvanen To: Peter Zijlstra Cc: Masahiro Yamada , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, George Burgess IV Subject: Re: [PATCH 06/22] kbuild: lto: limit inlining Message-ID: <20200624233724.GA94769@google.com> References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-7-samitolvanen@google.com> <20200624212055.GU4817@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624212055.GU4817@hirez.programming.kicks-ass.net> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Jun 24, 2020 at 11:20:55PM +0200, Peter Zijlstra wrote: > On Wed, Jun 24, 2020 at 01:31:44PM -0700, Sami Tolvanen wrote: > > This change limits function inlining across translation unit > > boundaries in order to reduce the binary size with LTO. > > > > The -import-instr-limit flag defines a size limit, as the number > > of LLVM IR instructions, for importing functions from other TUs. > > The default value is 100, and decreasing it to 5 reduces the size > > of a stripped arm64 defconfig vmlinux by 11%. > > Is that also the right number for x86? What about the effect on > performance? What did 6 do? or 4? This is the size limit we decided on for Android after testing on arm64, but the number is obviously a compromise between code size and performance. I'd be happy to benchmark this further once other concerns have been resolved. Sami