From: Jason Gunthorpe <jgg@nvidia.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
"mkubecek@suse.cz" <mkubecek@suse.cz>,
Aya Levin <ayal@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Tariq Toukan <tariqt@mellanox.com>,
"alexander.h.duyck@linux.intel.com"
<alexander.h.duyck@linux.intel.com>,
"jonathan.lemon@gmail.com" <jonathan.lemon@gmail.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [net-next 10/10] net/mlx5e: Add support for PCI relaxed ordering
Date: Fri, 10 Jul 2020 09:21:13 -0300 [thread overview]
Message-ID: <20200710122113.GR23676@nvidia.com> (raw)
In-Reply-To: <64f58446adb2536f87ea13cc5f0a88cd77d5cd5b.camel@mellanox.com>
On Fri, Jul 10, 2020 at 02:18:02AM +0000, Saeed Mahameed wrote:
> Be careful though to load driver with RO on and then setpci RO off..
> not sure what the side effects are, unstable driver maybe ?
According to the PCI spec HW should stop doing RO immediately once the
config space bit is cleared.
In any event continuing to issue RO won't harm anything.
> And not sure what should be the procedure then ? reload driver ? FW
> will get a notification from PCI ?
At worst you'd have to reload the driver - continuing to use RO if the
driver starts with RO off is seriously broken and probably won't work
with the quirks to disable RO on buggy platforms.
But as above, the RO config space bit should have immedaite effect on
the device and it should stop using RO. The device HW itself has to
enforce this to be spec compliant.
Jason
next prev parent reply other threads:[~2020-07-10 12:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200623195229.26411-1-saeedm@mellanox.com>
[not found] ` <20200623195229.26411-11-saeedm@mellanox.com>
[not found] ` <20200623143118.51373eb7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[not found] ` <dda5c2b729bbaf025592aa84e2bdb84d0cda7570.camel@mellanox.com>
[not found] ` <082c6bfe-5146-c213-9220-65177717c342@mellanox.com>
2020-06-24 17:22 ` [net-next 10/10] net/mlx5e: Add support for PCI relaxed ordering Jakub Kicinski
2020-06-24 20:15 ` Saeed Mahameed
[not found] ` <20200624133018.5a4d238b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2020-07-06 13:00 ` Aya Levin
2020-07-06 16:52 ` Jakub Kicinski
2020-07-06 19:49 ` David Miller
2040-07-08 8:22 ` Aya Levin
2020-07-08 23:16 ` Bjorn Helgaas
2020-07-08 23:26 ` Jason Gunthorpe
2020-07-09 17:35 ` Jonathan Lemon
2020-07-09 18:20 ` Jason Gunthorpe
2020-07-09 19:47 ` Jakub Kicinski
2020-07-10 2:18 ` Saeed Mahameed
2020-07-10 12:21 ` Jason Gunthorpe [this message]
2020-07-09 20:33 ` Jonathan Lemon
2020-07-14 10:47 ` Aya Levin
2020-07-23 21:03 ` Alexander Duyck
2020-06-26 20:12 ` Bjorn Helgaas
2020-06-26 20:24 ` David Miller
2020-06-29 9:32 ` Aya Levin
2020-06-29 19:33 ` Bjorn Helgaas
2020-06-29 19:57 ` Raj, Ashok
2020-06-30 7:32 ` Ding Tianhong
2020-07-05 11:15 ` Aya Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710122113.GR23676@nvidia.com \
--to=jgg@nvidia.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=ayal@mellanox.com \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).