From: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
To: bhelgaas@google.com, rjui@broadcom.com, sbranden@broadcom.com,
f.fainelli@gmail.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Subject: [PATCH 2/3] PCI: iproc: Stop using generic config read/write functions
Date: Thu, 30 Jul 2020 15:37:46 +1200 [thread overview]
Message-ID: <20200730033747.18931-2-mark.tomlinson@alliedtelesis.co.nz> (raw)
In-Reply-To: <20200730033747.18931-1-mark.tomlinson@alliedtelesis.co.nz>
The pci_generic_config_write32() function will give warning messages
whenever writing less than 4 bytes at a time. As there is nothing we can
do about this without changing the hardware, the message is just a
nuisance. So instead of using the generic functions, use the functions
that have already been written for reading/writing the config registers.
Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
---
drivers/pci/controller/pcie-iproc.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
index 2c836eede42c..68ecd3050529 100644
--- a/drivers/pci/controller/pcie-iproc.c
+++ b/drivers/pci/controller/pcie-iproc.c
@@ -709,12 +709,13 @@ static int iproc_pcie_config_read32(struct pci_bus *bus, unsigned int devfn,
{
int ret;
struct iproc_pcie *pcie = iproc_data(bus);
+ int busno = bus->number;
iproc_pcie_apb_err_disable(bus, true);
if (pcie->iproc_cfg_read)
ret = iproc_pcie_config_read(bus, devfn, where, size, val);
else
- ret = pci_generic_config_read32(bus, devfn, where, size, val);
+ ret = iproc_pci_raw_config_read32(pcie, busno, devfn, where, size, val);
iproc_pcie_apb_err_disable(bus, false);
return ret;
@@ -724,9 +725,11 @@ static int iproc_pcie_config_write32(struct pci_bus *bus, unsigned int devfn,
int where, int size, u32 val)
{
int ret;
+ struct iproc_pcie *pcie = iproc_data(bus);
+ int busno = bus->number;
iproc_pcie_apb_err_disable(bus, true);
- ret = pci_generic_config_write32(bus, devfn, where, size, val);
+ ret = iproc_pci_raw_config_write32(pcie, busno, devfn, where, size, val);
iproc_pcie_apb_err_disable(bus, false);
return ret;
--
2.28.0
next prev parent reply other threads:[~2020-07-30 3:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 3:37 [PATCH 1/3] PCI: iproc: Add bus number parameter to read/write functions Mark Tomlinson
2020-07-30 3:37 ` Mark Tomlinson [this message]
2020-07-30 16:09 ` [PATCH 2/3] PCI: iproc: Stop using generic config " Bjorn Helgaas
2020-07-30 16:36 ` Ray Jui
2020-07-30 16:45 ` Bjorn Helgaas
2020-07-30 22:58 ` Mark Tomlinson
2020-07-30 23:06 ` Bjorn Helgaas
2020-07-30 3:37 ` [PATCH 3/3] PCI: iproc: Set affinity mask on MSI interrupts Mark Tomlinson
2020-07-30 16:45 ` Ray Jui
2020-07-30 17:07 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730033747.18931-2-mark.tomlinson@alliedtelesis.co.nz \
--to=mark.tomlinson@alliedtelesis.co.nz \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).