From: Rob Herring <robh@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Ray Jui <rjui@broadcom.com>, Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Scott Branden <sbranden@broadcom.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] PCI: iproc: Fix using plain integer as NULL pointer in iproc_pcie_pltfm_probe
Date: Thu, 1 Oct 2020 12:07:01 -0500 [thread overview]
Message-ID: <20201001170701.GA709405@bogus> (raw)
In-Reply-To: <20200922194932.465925-1-kw@linux.com>
On Tue, Sep 22, 2020 at 07:49:32PM +0000, Krzysztof Wilczyński wrote:
> Fix sparse build warning:
>
> drivers/pci/controller/pcie-iproc-platform.c:102:33: warning: Using plain integer as NULL pointer
>
> The map_irq member of the struct iproc_pcie takes a function pointer
> serving as a callback to map interrupts, therefore we should pass a NULL
> pointer to it rather than a integer in the iproc_pcie_pltfm_probe()
> function.
>
> Related:
> commit b64aa11eb2dd ("PCI: Set bridge map_irq and swizzle_irq to
> default functions")
>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---
> drivers/pci/controller/pcie-iproc-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Not sure what I was smoking that day...
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-10-01 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 19:49 [PATCH] PCI: iproc: Fix using plain integer as NULL pointer in iproc_pcie_pltfm_probe Krzysztof Wilczyński
2020-10-01 17:07 ` Rob Herring [this message]
2020-10-09 12:43 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001170701.GA709405@bogus \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).