From: Bjorn Helgaas <helgaas@kernel.org>
To: Sean V Kelley <seanvk.dev@oregontracks.org>
Cc: bhelgaas@google.com, Jonathan.Cameron@huawei.com,
rafael.j.wysocki@intel.com, ashok.raj@intel.com,
tony.luck@intel.com, sathyanarayanan.kuppuswamy@intel.com,
qiuxu.zhuo@intel.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sean V Kelley <sean.v.kelley@intel.com>
Subject: Re: [PATCH v8 00/14] Add RCEC handling to PCI/AER
Date: Fri, 9 Oct 2020 10:53:10 -0500 [thread overview]
Message-ID: <20201009155310.GA3477892@bjorn-Precision-5520> (raw)
In-Reply-To: <20201002184735.1229220-1-seanvk.dev@oregontracks.org>
On Fri, Oct 02, 2020 at 11:47:21AM -0700, Sean V Kelley wrote:
> From: Sean V Kelley <sean.v.kelley@intel.com>
>
> Changes since v7 [1]:
>
> - No functional changes.
>
> - Reword bridge patch.
> - Noted testing below for #non-native/no RCEC case
> (Jonathan Cameron)
>
> - Separate out pci_walk_bus() into pci_walk_bridge() change.
> - Put remaining dev to bridge name changes in the separate patch from v7.
> (Bjorn Helgaas)
>
> [1] https://lore.kernel.org/lkml/20200930215820.1113353-1-seanvk.dev@oregontracks.org/
>
> Root Complex Event Collectors (RCEC) provide support for terminating error
> and PME messages from Root Complex Integrated Endpoints (RCiEPs). An RCEC
> resides on a Bus in the Root Complex. Multiple RCECs can in fact reside on
> a single bus. An RCEC will explicitly declare supported RCiEPs through the
> Root Complex Endpoint Association Extended Capability.
>
> (See PCIe 5.0-1, sections 1.3.2.3 (RCiEP), and 7.9.10 (RCEC Ext. Cap.))
>
> The kernel lacks handling for these RCECs and the error messages received
> from their respective associated RCiEPs. More recently, a new CPU
> interconnect, Compute eXpress Link (CXL) depends on RCEC capabilities for
> purposes of error messaging from CXL 1.1 supported RCiEP devices.
>
> DocLink: https://www.computeexpresslink.org/
>
> This use case is not limited to CXL. Existing hardware today includes
> support for RCECs, such as the Denverton microserver product
> family. Future hardware will be forthcoming.
>
> (See Intel Document, Order number: 33061-003US)
>
> So services such as AER or PME could be associated with an RCEC driver.
> In the case of CXL, if an RCiEP (i.e., CXL 1.1 device) is associated with a
> platform's RCEC it shall signal PME and AER error conditions through that
> RCEC.
>
> Towards the above use cases, add the missing RCEC class and extend the
> PCIe Root Port and service drivers to allow association of RCiEPs to their
> respective parent RCEC and facilitate handling of terminating error and PME
> messages.
>
> Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #non-native/no RCEC
>
>
> Jonathan Cameron (1):
> PCI/AER: Extend AER error handling to RCECs
>
> Qiuxu Zhuo (5):
> PCI/RCEC: Add RCEC class code and extended capability
> PCI/RCEC: Bind RCEC devices to the Root Port driver
> PCI/AER: Apply function level reset to RCiEP on fatal error
> PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR
> PCI/AER: Add RCEC AER error injection support
>
> Sean V Kelley (8):
> PCI/RCEC: Cache RCEC capabilities in pci_init_capabilities()
> PCI/ERR: Rename reset_link() to reset_subordinate_device()
> PCI/ERR: Use "bridge" for clarity in pcie_do_recovery()
> PCI/ERR: Add pci_walk_bridge() to pcie_do_recovery()
> PCI/ERR: Limit AER resets in pcie_do_recovery()
> PCI/RCEC: Add pcie_link_rcec() to associate RCiEPs
> PCI/AER: Add pcie_walk_rcec() to RCEC AER handling
> PCI/PME: Add pcie_walk_rcec() to RCEC PME handling
>
> drivers/pci/pci.h | 25 ++++-
> drivers/pci/pcie/Makefile | 2 +-
> drivers/pci/pcie/aer.c | 36 ++++--
> drivers/pci/pcie/aer_inject.c | 5 +-
> drivers/pci/pcie/err.c | 109 +++++++++++++++----
> drivers/pci/pcie/pme.c | 15 ++-
> drivers/pci/pcie/portdrv_core.c | 8 +-
> drivers/pci/pcie/portdrv_pci.c | 8 +-
> drivers/pci/pcie/rcec.c | 187 ++++++++++++++++++++++++++++++++
> drivers/pci/probe.c | 2 +
> include/linux/pci.h | 5 +
> include/linux/pci_ids.h | 1 +
> include/uapi/linux/pci_regs.h | 7 ++
> 13 files changed, 367 insertions(+), 43 deletions(-)
> create mode 100644 drivers/pci/pcie/rcec.c
Thank you very much for your work and patience with this series!
Applied to pci/err for v5.10 with the following changes:
- Make pci_rcec_init() void since return value was unused.
- Reorder pci_rcec_init() so rcec_ea is filled in before publishing
in dev->rcec_ea.
- Split pcie_do_recovery() patches up a little more. My hope was to
make the "Use 'bridge' for clarity" patch more of a pure rename
patch and easier to review. Not sure I accomplished that.
- Log messages and uevents with "bridge", not "dev", in
pcie_do_recovery() to preserve previous behavior.
- Rename reset_subordinate_devices() to reset_subordinates() for
brevity.
- Fix kerneldoc issues (reported with "make W=1").
- Fix whitespace (lines didn't use the full width or > 80 columns,
etc).
Please let me know if I botched anything.
prev parent reply other threads:[~2020-10-09 15:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 18:47 [PATCH v8 00/14] Add RCEC handling to PCI/AER Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 01/14] PCI/RCEC: Add RCEC class code and extended capability Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 02/14] PCI/RCEC: Bind RCEC devices to the Root Port driver Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 03/14] PCI/RCEC: Cache RCEC capabilities in pci_init_capabilities() Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 04/14] PCI/ERR: Rename reset_link() to reset_subordinate_device() Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 05/14] PCI/ERR: Use "bridge" for clarity in pcie_do_recovery() Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 06/14] PCI/ERR: Add pci_walk_bridge() to pcie_do_recovery() Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 07/14] PCI/ERR: Limit AER resets in pcie_do_recovery() Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 08/14] PCI/AER: Extend AER error handling to RCECs Sean V Kelley
2020-10-09 21:27 ` Bjorn Helgaas
2020-10-09 21:54 ` Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 09/14] PCI/AER: Apply function level reset to RCiEP on fatal error Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 10/14] PCI/RCEC: Add pcie_link_rcec() to associate RCiEPs Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 11/14] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR Sean V Kelley
2020-10-09 17:57 ` Bjorn Helgaas
2020-10-09 18:26 ` Sean V Kelley
2020-10-09 18:34 ` Sean V Kelley
2020-10-09 18:53 ` Sean V Kelley
2020-10-09 19:48 ` Sean V Kelley
2020-10-09 21:30 ` Bjorn Helgaas
2020-10-09 22:07 ` Sean V Kelley
2020-10-09 23:51 ` Kelley, Sean V
2020-10-12 22:58 ` Bjorn Helgaas
2020-10-13 16:55 ` Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 12/14] PCI/AER: Add pcie_walk_rcec() to RCEC AER handling Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 13/14] PCI/PME: Add pcie_walk_rcec() to RCEC PME handling Sean V Kelley
2020-10-02 18:47 ` [PATCH v8 14/14] PCI/AER: Add RCEC AER error injection support Sean V Kelley
2020-10-09 15:53 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009155310.GA3477892@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@intel.com \
--cc=sean.v.kelley@intel.com \
--cc=seanvk.dev@oregontracks.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).