From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Rob Herring <robh@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jason Cooper <jason@lakedaemon.net>,
linux-pci@vger.kernel.org, vtolkm@googlemail.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: mvebu: Fix duplicate resource requests
Date: Thu, 22 Oct 2020 23:09:24 +0100 [thread overview]
Message-ID: <20201022220924.GX1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20201022220507.GW1551@shell.armlinux.org.uk>
On Thu, Oct 22, 2020 at 11:05:07PM +0100, Russell King - ARM Linux admin wrote:
> > @@ -1001,9 +995,12 @@ static int mvebu_pcie_parse_request_resources(struct mvebu_pcie *pcie)
> > pcie->realio.name = "PCI I/O";
> >
> > pci_add_resource(&bridge->windows, &pcie->realio);
> > + ret = devm_request_resource(dev, &iomem_resource, &pcie->realio);
>
> I think you're trying to claim this resource against the wrong parent.
Fixing this to ioport_resource results in in working PCIe.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-10-22 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 22:00 [PATCH] PCI: mvebu: Fix duplicate resource requests Rob Herring
2020-10-22 22:05 ` Russell King - ARM Linux admin
2020-10-22 22:09 ` Russell King - ARM Linux admin [this message]
2020-10-23 0:51 ` Rob Herring
2020-10-23 9:12 ` ™֟☻̭҇ Ѽ ҉ ®
2020-10-23 15:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022220924.GX1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=bhelgaas@google.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vtolkm@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).