From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5769FC388F2 for ; Mon, 2 Nov 2020 15:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E99C22275 for ; Mon, 2 Nov 2020 15:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604330650; bh=RnZzNGAnLLIjc/EuCst7D7QPRlFlRXZlglvbfb5ZJUM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xtGBb3t8NQwr3lj8Elywf801d00FlyeYhw4TMZwl2rRystu/UhvzJFDk4okPMNxqC xL7LWXQ+AGYTWCRZv/u2uDWdKO6gHxPbHzTcWnUxh8TDecbbYBRV3Qbdwr5cKILdNg sWpNwOGdzB/7Fxwzyn4m2ppgJ7nFLMIB0aT/Hyls= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726043AbgKBPYH (ORCPT ); Mon, 2 Nov 2020 10:24:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:34052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgKBPYH (ORCPT ); Mon, 2 Nov 2020 10:24:07 -0500 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 398D42222B; Mon, 2 Nov 2020 15:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604330646; bh=RnZzNGAnLLIjc/EuCst7D7QPRlFlRXZlglvbfb5ZJUM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Li9sxcf2WK0rftgkTcs7d49GpF5tvCamgjxLGJ/SIjg57aBbrHvsaNt9xDqvsBFag hAbrWSEiITTeGQ2iG0exts1GsWQfcbJwC5zK/dc+o+k/wkzJbHEGha+GUwI+7fg9oP A2xf+pA3lO0JCSy6Up48UzHGpwHDAxHgcxU3shpU= Received: by pali.im (Postfix) id 9477112CC; Mon, 2 Nov 2020 16:24:03 +0100 (CET) Date: Mon, 2 Nov 2020 16:24:03 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Cc: vtolkm@gmail.com, Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Ilias Apalodimas , Marek =?utf-8?B?QmVow7pu?= , Thomas Petazzoni , Jason Cooper Subject: Re: PCI trouble on mvebu (Turris Omnia) Message-ID: <20201102152403.4jlmcaqkqeivuypm@pali> References: <2fb69e2a-4423-2b04-cd0f-ca819092bc5f@gmail.com> <20201028231626.GA344207@bjorn-Precision-5520> <20201030112331.meqg6lvultyn6v54@pali> <87k0v7n9y9.fsf@toke.dk> <20201030142337.yushrdcuecycfhcu@pali> <87zh42lfv6.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zh42lfv6.fsf@toke.dk> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Saturday 31 October 2020 13:49:49 Toke Høiland-Jørgensen wrote: > "™֟☻̭҇ Ѽ ҉ ®" writes: > > > On 30/10/2020 15:23, Pali Rohár wrote: > >> On Friday 30 October 2020 14:02:22 Toke Høiland-Jørgensen wrote: > >>> Pali Rohár writes: > >>>> My experience with that WLE900VX card, aardvark driver and aspm code: > >>>> > >>>> Link training in GEN2 mode for this card succeed only once after reset. > >>>> Repeated link retraining fails and it fails even when aardvark is > >>>> reconfigured to GEN1 mode. Reset via PERST# signal is required to have > >>>> working link training. > >>>> > >>>> What I did in aardvark driver: Set mode to GEN2, do link training. If > >>>> success read "negotiated link speed" from "Link Control Status Register" > >>>> (for WLE900VX it is 0x1 - GEN1) and set it into aardvark. And then > >>>> retrain link again (for WLE900VX now it would be at GEN1). After that > >>>> card is stable and all future retraining (e.g. from aspm.c) also passes. > >>>> > >>>> If I do not change aardvark mode from GEN2 to GEN1 the second link > >>>> training fails. And if I change mode to GEN1 after this failed link > >>>> training then nothing happen, link training do not success. > >>>> > >>>> So just speculation now... In current setup initialization of card does > >>>> one link training at GEN2. Then aspm.c is called which is doing second > >>>> link retraining at GEN2. And if it fails then below patch issue third > >>>> link retraining at GEN1. If A38x/pci-mvebu has same problem as aardvark > >>>> then second link retraining must be at GEN1 (not GEN2) to workaround > >>>> this issue. > >>>> > >>>> Bjorn, Toke: what about trying to hack aspm.c code to never do link > >>>> retraining at GEN2 speed? And always force GEN1 speed prior link > >>>> training? > >>> Sounds like a plan. I poked around in aspm.c and must confess to being a > >>> bit lost in the soup of registers ;) > >>> > >>> So if one of you can cook up a patch, that would be most helpful! > >> I modified Bjorn's patch, explicitly set tls to 1 and added debug info > >> about cls (current link speed, that what is used by aardvark). It is > >> untested, I just tried to compile it. > >> > >> Can try it? > >> > >> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c > >> index 253c30cc1967..f934c0b52f41 100644 > >> --- a/drivers/pci/pcie/aspm.c > >> +++ b/drivers/pci/pcie/aspm.c > >> @@ -206,6 +206,27 @@ static bool pcie_retrain_link(struct pcie_link_state *link) > >> unsigned long end_jiffies; > >> u16 reg16; > >> > >> + u32 lnkcap2; > >> + u16 lnksta, lnkctl2, cls, tls; > >> + > >> + pcie_capability_read_dword(parent, PCI_EXP_LNKCAP2, &lnkcap2); > >> + pcie_capability_read_word(parent, PCI_EXP_LNKSTA, &lnksta); > >> + pcie_capability_read_word(parent, PCI_EXP_LNKCTL2, &lnkctl2); > >> + cls = lnksta & PCI_EXP_LNKSTA_CLS; > >> + tls = lnkctl2 & PCI_EXP_LNKCTL2_TLS; > >> + > >> + pci_info(parent, "lnkcap2 %#010x sls %#04x lnksta %#06x cls %#03x lnkctl2 %#06x tls %#03x\n", > >> + lnkcap2, (lnkcap2 & 0x3F) >> 1, > >> + lnksta, cls, > >> + lnkctl2, tls); > >> + > >> + tls = 1; > >> + pcie_capability_clear_and_set_word(parent, PCI_EXP_LNKCTL2, > >> + PCI_EXP_LNKCTL2_TLS, tls); > >> + pcie_capability_read_word(parent, PCI_EXP_LNKCTL2, &lnkctl2); > >> + pci_info(parent, "lnkctl2 %#010x new tls %#03x\n", > >> + lnkctl2, tls); > >> + > >> pcie_capability_read_word(parent, PCI_EXP_LNKCTL, ®16); > >> reg16 |= PCI_EXP_LNKCTL_RL; > >> pcie_capability_write_word(parent, PCI_EXP_LNKCTL, reg16); > >> @@ -227,6 +248,8 @@ static bool pcie_retrain_link(struct pcie_link_state *link) > >> break; > >> msleep(1); > >> } while (time_before(jiffies, end_jiffies)); > >> + pci_info(parent, "lnksta %#06x new cls %#03x\n", > >> + lnksta, (cls & PCI_EXP_LNKSTA_CLS)); > >> return !(reg16 & PCI_EXP_LNKSTA_LT); > >> } > >> > > > > Still exhibiting the BAR update error, run tested with next--20201030 > > Yup, same for me :( So then it is different issue and not similar to aardvark one. Anyway, was ASPM working on some previous kernel version? Or was it always broken on Turris Omnia? And has somebody other Armada 385 device with mPCIe slots to test if ASPM is working? Or any other 32bit Marvell Armada SOC? I would like to know if this is issue only on Turris Omnia or also on other Armada 385 SOC device or even on any other device which uses pci-mvebu.c driver.