From: Bjorn Helgaas <helgaas@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jaehoon Chung <jh80.chung@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 0/6] Add DW PCIe support for Exynos5433 SoCs
Date: Tue, 3 Nov 2020 16:44:37 -0600 [thread overview]
Message-ID: <20201103224437.GA271545@bjorn-Precision-5520> (raw)
In-Reply-To: <20201029134017.27400-1-m.szyprowski@samsung.com>
On Thu, Oct 29, 2020 at 02:40:11PM +0100, Marek Szyprowski wrote:
> Dear All,
>
> This patchset is a resurrection of the DW PCIe support for the Exynos5433
> SoCs posted long time ago here: https://lkml.org/lkml/2016/12/26/6 and
> later here: https://lkml.org/lkml/2017/12/21/296 .
>
> In meantime the support for the Exynos5440 SoCs has been completely
> dropped from mainline kernel, as those SoCs never reached the market. The
> PCIe driver for Exynos5440 variant however has not been removed yet. This
> patchset simply reworks it to support the Exynos5433 variant. The lack of
> the need to support both variants significantly simplifies the driver
> code.
>
> This patchset is based on the following branch:
> git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-more-dwc-cleanup
>
> Best regards,
> Marek Szyprowski
>
>
> Changelog:
>
> v3:
> - rebased onto "[00/13] PCI: dwc: Another round of clean-ups" patchset:
> https://patchwork.kernel.org/project/linux-samsung-soc/cover/20201028204646.356535-1-robh@kernel.org/
> - fixed issues pointed by Rob in the driver logic:
> * removed DBI_RO_WR_EN register poking
> * made driver a standard module
> - fixed section mismatch issue
> - added "num-viewport = <3>" property to dts and bindings to fix warning
>
> v2: https://lore.kernel.org/linux-samsung-soc/20201023075744.26200-1-m.szyprowski@samsung.com/
> - fixed issues in dt-bindings pointed by Krzysztof and Rob
>
> v1: https://lore.kernel.org/linux-samsung-soc/20201019094715.15343-1-m.szyprowski@samsung.com/
> - initial version of this resurrected patchset
>
>
> Patch summary:
Please follow the subject line convention:
PCI: exynos: Rework to support Exynos5433 variant
arm64: dts: exynos: Add WiFi/PCIe support to TM2(e) boards
dt-bindings: PCI: exynos: Drop samsung,exynos5440-pcie binding
dt-bindings: PCI: exynos: Add samsung,exynos-pcie binding
dt-bindings: phy: exynos: Add samsung,exynos-pcie-phy binding
You can save this trouble by running "git log --oneline" on the file
(or directory, for new files) and copying the style.
> Jaehoon Chung (3):
> phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433
> PCIe PHY
> pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant
> arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards
>
> Marek Szyprowski (3):
> dt-bindings: pci: drop samsung,exynos5440-pcie binding
> dt-bindings: pci: add the samsung,exynos-pcie binding
> dt-bindings: phy: add the samsung,exynos-pcie-phy binding
>
> .../bindings/pci/samsung,exynos-pcie.yaml | 119 ++++++
> .../bindings/pci/samsung,exynos5440-pcie.txt | 58 ---
> .../bindings/phy/samsung,exynos-pcie-phy.yaml | 51 +++
> .../boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +-
> .../dts/exynos/exynos5433-tm2-common.dtsi | 24 +-
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 36 ++
> drivers/pci/controller/dwc/Kconfig | 10 +-
> drivers/pci/controller/dwc/pci-exynos.c | 353 +++++++-----------
> drivers/pci/quirks.c | 1 +
> drivers/phy/samsung/phy-exynos-pcie.c | 304 ++++++---------
> 10 files changed, 489 insertions(+), 469 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
> delete mode 100644 Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt
> create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos-pcie-phy.yaml
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-11-03 22:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201029134037eucas1p17f861adc0858e8a80d516dc0f2733f84@eucas1p1.samsung.com>
2020-10-29 13:40 ` [PATCH v3 0/6] Add DW PCIe support for Exynos5433 SoCs Marek Szyprowski
[not found] ` <CGME20201029134037eucas1p275bad9fe08eff145711cc36ac8c685f7@eucas1p2.samsung.com>
2020-10-29 13:40 ` [PATCH v3 1/6] dt-bindings: pci: drop samsung,exynos5440-pcie binding Marek Szyprowski
[not found] ` <CGME20201029134038eucas1p28d9bd33bc9e36b960b021a40ef299b47@eucas1p2.samsung.com>
2020-10-29 13:40 ` [PATCH v3 2/6] dt-bindings: pci: add the samsung,exynos-pcie binding Marek Szyprowski
2020-11-04 21:35 ` Rob Herring
2020-11-05 8:33 ` Marek Szyprowski
2020-11-05 15:27 ` Rob Herring
2020-11-05 17:14 ` Jingoo Han
[not found] ` <CGME20201029134038eucas1p2d550a45ff3222ccb72d15d5c89d4f938@eucas1p2.samsung.com>
2020-10-29 13:40 ` [PATCH v3 3/6] dt-bindings: phy: add the samsung,exynos-pcie-phy binding Marek Szyprowski
2020-11-04 21:39 ` Rob Herring
[not found] ` <CGME20201029134039eucas1p2270e5f4ecea05b17f4d9107300ce946d@eucas1p2.samsung.com>
2020-10-29 13:40 ` [PATCH v3 4/6] phy: samsung: phy-exynos-pcie: rework driver to support Exynos5433 PCIe PHY Marek Szyprowski
[not found] ` <CGME20201029134040eucas1p1d9ab30c75ac9243346b4786e7048d6be@eucas1p1.samsung.com>
2020-10-29 13:40 ` [PATCH v3 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant Marek Szyprowski
2020-10-29 21:59 ` Jingoo Han
2020-11-04 21:39 ` Rob Herring
[not found] ` <CGME20201029134040eucas1p2a8958b44842a8a4647e3aa4521c75725@eucas1p2.samsung.com>
2020-10-29 13:40 ` [PATCH v3 6/6] arm64: dts: exynos: add the WiFi/PCIe support to TM2(e) boards Marek Szyprowski
2020-11-05 19:14 ` Krzysztof Kozlowski
2020-11-03 22:44 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103224437.GA271545@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).