From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Raju Rangoju <rajur@chelsio.com>,
David Miller <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/4] PCI/VPD: Remove Chelsio T3 quirk
Date: Wed, 3 Feb 2021 18:30:19 -0800 [thread overview]
Message-ID: <20210203183019.7c9a5004@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <a64e550c-b8d2-889e-1f55-019b10060c1b@gmail.com>
On Tue, 2 Feb 2021 21:35:55 +0100 Heiner Kallweit wrote:
> cxgb3 driver doesn't use the PCI core code for VPD access, it has its own
> implementation. Therefore we don't need a quirk for it in the core code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Would this not affect the size of the file under sysfs?
> diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
> index 7915d10f9..db86fe226 100644
> --- a/drivers/pci/vpd.c
> +++ b/drivers/pci/vpd.c
> @@ -628,22 +628,17 @@ static void quirk_chelsio_extend_vpd(struct pci_dev *dev)
> {
> int chip = (dev->device & 0xf000) >> 12;
> int func = (dev->device & 0x0f00) >> 8;
> - int prod = (dev->device & 0x00ff) >> 0;
>
> /*
> - * If this is a T3-based adapter, there's a 1KB VPD area at offset
> - * 0xc00 which contains the preferred VPD values. If this is a T4 or
> - * later based adapter, the special VPD is at offset 0x400 for the
> - * Physical Functions (the SR-IOV Virtual Functions have no VPD
> - * Capabilities). The PCI VPD Access core routines will normally
> + * If this is a T4 or later based adapter, the special VPD is at offset
> + * 0x400 for the Physical Functions (the SR-IOV Virtual Functions have
> + * no VPD Capabilities). The PCI VPD Access core routines will normally
> * compute the size of the VPD by parsing the VPD Data Structure at
> * offset 0x000. This will result in silent failures when attempting
> * to accesses these other VPD areas which are beyond those computed
> * limits.
> */
> - if (chip == 0x0 && prod >= 0x20)
> - pci_set_vpd_size(dev, 8192);
> - else if (chip >= 0x4 && func < 0x8)
> + if (chip >= 0x4 && func < 0x8)
> pci_set_vpd_size(dev, 2048);
> }
>
next prev parent reply other threads:[~2021-02-04 2:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 20:34 [PATCH net-next 0/4] chelsio: improve PCI VPD handling Heiner Kallweit
2021-02-02 20:35 ` [PATCH net-next 1/4] PCI/VPD: Remove Chelsio T3 quirk Heiner Kallweit
2021-02-04 2:30 ` Jakub Kicinski [this message]
2021-02-04 7:18 ` Heiner Kallweit
2021-02-05 12:42 ` Raju Rangoju
2021-02-05 14:01 ` Heiner Kallweit
2021-02-02 20:37 ` [PATCH net-next 2/4] cxgb4: remove unused vpd_cap_addr Heiner Kallweit
2021-02-02 20:38 ` [PATCH net-next 3/4] PCI/VPD: Change Chelsio T4 quirk to provide access to full virtual EEPROM address space Heiner Kallweit
2021-02-02 20:39 ` [PATCH net-next 4/4] cxgb4: remove changing VPD len Heiner Kallweit
2021-02-04 2:31 ` [PATCH net-next 0/4] chelsio: improve PCI VPD handling Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203183019.7c9a5004@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).