From: Jason Gunthorpe <jgg@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
linux-rdma@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
Don Dutile <ddutile@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count
Date: Thu, 11 Mar 2021 16:31:40 -0400 [thread overview]
Message-ID: <20210311203140.GP2356281@nvidia.com> (raw)
In-Reply-To: <20210311181729.GA2148230@bjorn-Precision-5520>
On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote:
> > In addition it still feels rather hacky to be modifying read-only PCIe
> > configuration space on the fly via a backdoor provided by the PF. It
> > almost feels like this should be some sort of quirk rather than a
> > standard feature for an SR-IOV VF.
>
> I agree, I'm not 100% comfortable with modifying the read-only Table
> Size register. Maybe there's another approach that would be better?
> It *is* nice that the current approach doesn't require changes in the
> VF driver.
Right, that is the whole point here - if we wanted to change every
driver we could do that in some other way. Changing the table size
register is the only way to keep existing drivers working.
Jason
next prev parent reply other threads:[~2021-03-11 20:32 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 7:55 [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count Leon Romanovsky
2021-03-01 7:55 ` [PATCH mlx5-next v7 1/4] PCI: Add a sysfs file to change the MSI-X table size of SR-IOV VFs Leon Romanovsky
2021-03-01 8:14 ` Greg Kroah-Hartman
2021-03-01 8:32 ` Leon Romanovsky
2021-03-01 8:37 ` Greg Kroah-Hartman
2021-03-01 8:53 ` Leon Romanovsky
2021-03-01 7:55 ` [PATCH mlx5-next v7 2/4] net/mlx5: Add dynamic MSI-X capabilities bits Leon Romanovsky
2021-03-01 7:55 ` [PATCH mlx5-next v7 3/4] net/mlx5: Dynamically assign MSI-X vectors count Leon Romanovsky
2021-03-01 7:55 ` [PATCH mlx5-next v7 4/4] net/mlx5: Implement sriov_get_vf_total_msix/count() callbacks Leon Romanovsky
2021-03-07 8:11 ` [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count Leon Romanovsky
2021-03-07 18:55 ` Alexander Duyck
2021-03-07 19:19 ` Leon Romanovsky
2021-03-08 16:33 ` Alexander Duyck
2021-03-08 19:20 ` Leon Romanovsky
2021-03-10 19:09 ` Bjorn Helgaas
2021-03-10 20:10 ` Leon Romanovsky
2021-03-10 20:21 ` Greg Kroah-Hartman
2021-03-11 8:37 ` Leon Romanovsky
2021-03-10 23:34 ` Alexander Duyck
2021-03-11 18:17 ` Bjorn Helgaas
2021-03-11 19:16 ` Keith Busch
2021-03-11 19:21 ` Leon Romanovsky
2021-03-11 20:22 ` Jason Gunthorpe
2021-03-11 20:50 ` Keith Busch
2021-03-11 21:44 ` Jason Gunthorpe
2021-03-25 17:21 ` Bjorn Helgaas
2021-03-25 17:36 ` Jason Gunthorpe
2021-03-25 18:20 ` Bjorn Helgaas
2021-03-25 18:28 ` Jason Gunthorpe
2021-03-26 6:44 ` Leon Romanovsky
2021-03-26 16:00 ` Alexander Duyck
2021-03-26 16:56 ` Jason Gunthorpe
2021-03-26 17:08 ` Bjorn Helgaas
2021-03-26 17:12 ` Jason Gunthorpe
2021-03-27 6:00 ` Leon Romanovsky
2021-03-26 17:29 ` Keith Busch
2021-03-26 17:31 ` Jason Gunthorpe
2021-03-26 18:50 ` Alexander Duyck
2021-03-26 19:01 ` Jason Gunthorpe
2021-03-30 1:29 ` Bjorn Helgaas
2021-03-30 13:57 ` Jason Gunthorpe
2021-03-30 15:00 ` Bjorn Helgaas
2021-03-30 19:47 ` Jason Gunthorpe
2021-03-30 20:41 ` Bjorn Helgaas
2021-03-30 22:43 ` Jason Gunthorpe
2021-03-31 6:38 ` Greg Kroah-Hartman
2021-03-31 12:19 ` Jason Gunthorpe
2021-03-31 15:03 ` Greg Kroah-Hartman
2021-03-31 17:07 ` Jason Gunthorpe
2021-03-31 4:08 ` Leon Romanovsky
2021-04-01 1:23 ` Bjorn Helgaas
2021-04-01 11:49 ` Leon Romanovsky
2021-03-30 18:10 ` Keith Busch
2021-03-26 19:36 ` Bjorn Helgaas
2021-03-27 12:38 ` Greg Kroah-Hartman
2021-03-25 18:31 ` Keith Busch
2021-03-25 18:36 ` Jason Gunthorpe
2021-03-11 19:17 ` Leon Romanovsky
2021-03-11 19:37 ` Alexander Duyck
2021-03-11 19:51 ` Leon Romanovsky
2021-03-11 20:11 ` Alexander Duyck
2021-03-11 20:19 ` Jason Gunthorpe
2021-03-11 21:49 ` Alexander Duyck
2021-03-11 23:20 ` Jason Gunthorpe
2021-03-12 2:53 ` Alexander Duyck
2021-03-12 6:32 ` Leon Romanovsky
2021-03-12 16:59 ` Alexander Duyck
2021-03-12 17:03 ` Jason Gunthorpe
2021-03-12 18:34 ` Leon Romanovsky
2021-03-12 18:41 ` Leon Romanovsky
2021-03-12 13:00 ` Jason Gunthorpe
2021-03-12 13:36 ` Keith Busch
2021-03-11 20:31 ` Jason Gunthorpe [this message]
2021-03-10 5:58 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311203140.GP2356281@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ddutile@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).