From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF36C4338F for ; Mon, 23 Aug 2021 16:42:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72BD661371 for ; Mon, 23 Aug 2021 16:42:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229471AbhHWQnZ (ORCPT ); Mon, 23 Aug 2021 12:43:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:38190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbhHWQnY (ORCPT ); Mon, 23 Aug 2021 12:43:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EBC996124B; Mon, 23 Aug 2021 16:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629736962; bh=Noz1/fUIuPdZh4oSdO5S2IJ/Q2VuZ8ZcDqLTvICeD3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k1tzJOhD9ePClgY04kcZfgRYmcalXb+k0IQzI/2RdkLde/OpEJRIgXlOvsIPnw0c9 mP1kivM/xGcybZkA/Cv/965c52TmW/EYEaXms7FiagnEqNxBhSysfdteDSgH0PD216 BeqiGuf/fgLkE8S0B7JNlggg9aI2er0NSPxVUtQW+Hz6XilNXLOeQYYd89yzS6Q7TE SDy0Y6l1sWSz7MO7oXX4QkRa3NHhRMTVI5iM7oL4oj4kDvrf58JQm3H/zO5ojXqd1Z HyICYYcfaxfewGEAk4GiPNtpm7EkkhP5AyRAUwO9vpqBSsRgAdLL7Z4dLbVxTLloxH trgXpWvN6ApQA== Received: by pali.im (Postfix) id D8F37FC2; Mon, 23 Aug 2021 18:42:39 +0200 (CEST) Date: Mon, 23 Aug 2021 18:42:39 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marc Zyngier Cc: Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas , Rob Herring , Marek =?utf-8?B?QmVow7pu?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] PCI: aardvark: Correctly clear and unmask all MSI interrupts Message-ID: <20210823164239.beooev5ytrbcsxxr@pali> References: <20210625090319.10220-1-pali@kernel.org> <20210625090319.10220-7-pali@kernel.org> <20210806083522.arnxu7cikgzn73b4@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210806083522.arnxu7cikgzn73b4@pali> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Friday 06 August 2021 10:35:22 Pali Rohár wrote: > On Friday 06 August 2021 09:32:24 Marc Zyngier wrote: > > On 2021-06-25 10:03, Pali Rohár wrote: > > > Define a new macro PCIE_MSI_ALL_MASK and use it for masking, unmasking > > > and > > > clearing all MSI interrupts. > > > > > > Signed-off-by: Pali Rohár > > > Reviewed-by: Marek Behún > > > Cc: stable@vger.kernel.org > > > --- > > > drivers/pci/controller/pci-aardvark.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/pci/controller/pci-aardvark.c > > > b/drivers/pci/controller/pci-aardvark.c > > > index 0e81d89f307d..7cad6d989f6c 100644 > > > --- a/drivers/pci/controller/pci-aardvark.c > > > +++ b/drivers/pci/controller/pci-aardvark.c > > > @@ -117,6 +117,7 @@ > > > #define PCIE_MSI_ADDR_HIGH_REG (CONTROL_BASE_ADDR + 0x54) > > > #define PCIE_MSI_STATUS_REG (CONTROL_BASE_ADDR + 0x58) > > > #define PCIE_MSI_MASK_REG (CONTROL_BASE_ADDR + 0x5C) > > > +#define PCIE_MSI_ALL_MASK GENMASK(31, 0) > > > #define PCIE_MSI_PAYLOAD_REG (CONTROL_BASE_ADDR + 0x9C) > > > #define PCIE_MSI_DATA_MASK GENMASK(15, 0) > > > > > > @@ -470,19 +471,22 @@ static void advk_pcie_setup_hw(struct advk_pcie > > > *pcie) > > > advk_writel(pcie, reg, PCIE_CORE_CTRL2_REG); > > > > > > /* Clear all interrupts */ > > > + advk_writel(pcie, PCIE_MSI_ALL_MASK, PCIE_MSI_STATUS_REG); > > > advk_writel(pcie, PCIE_ISR0_ALL_MASK, PCIE_ISR0_REG); > > > advk_writel(pcie, PCIE_ISR1_ALL_MASK, PCIE_ISR1_REG); > > > advk_writel(pcie, PCIE_IRQ_ALL_MASK, HOST_CTRL_INT_STATUS_REG); > > > > > > /* Disable All ISR0/1 Sources */ > > > - reg = PCIE_ISR0_ALL_MASK; > > > - reg &= ~PCIE_ISR0_MSI_INT_PENDING; > > > - advk_writel(pcie, reg, PCIE_ISR0_MASK_REG); > > > - > > > + advk_writel(pcie, PCIE_ISR0_ALL_MASK, PCIE_ISR0_MASK_REG); > > > advk_writel(pcie, PCIE_ISR1_ALL_MASK, PCIE_ISR1_MASK_REG); > > > > > > /* Unmask all MSIs */ > > > - advk_writel(pcie, 0, PCIE_MSI_MASK_REG); > > > + advk_writel(pcie, ~(u32)PCIE_MSI_ALL_MASK, PCIE_MSI_MASK_REG); > > > + > > > + /* Unmask summary MSI interrupt */ > > > + reg = advk_readl(pcie, PCIE_ISR0_MASK_REG); > > > + reg &= ~PCIE_ISR0_MSI_INT_PENDING; > > > + advk_writel(pcie, reg, PCIE_ISR0_MASK_REG); > > > > > > /* Enable summary interrupt for GIC SPI source */ > > > reg = PCIE_IRQ_ALL_MASK & (~PCIE_IRQ_ENABLE_INTS_MASK); > > > @@ -1177,7 +1181,7 @@ static void advk_pcie_handle_msi(struct advk_pcie > > > *pcie) > > > > > > msi_mask = advk_readl(pcie, PCIE_MSI_MASK_REG); > > > msi_val = advk_readl(pcie, PCIE_MSI_STATUS_REG); > > > - msi_status = msi_val & ~msi_mask; > > > + msi_status = msi_val & ((~msi_mask) & PCIE_MSI_ALL_MASK); > > > > > > for (msi_idx = 0; msi_idx < MSI_IRQ_NUM; msi_idx++) { > > > if (!(BIT(msi_idx) & msi_status)) > > > > This still begs the question: why would you ever enable all > > MSIs the first place? They should be enabled on request only. > > This is going to be fixed in followup patches. Just Lorenzo asked to > send smaller patch series, so I have to split that followup fix into > the next round. Just for reference, patch series which is handling it: https://lore.kernel.org/linux-pci/20210815103624.19528-1-pali@kernel.org/t/#u > > M. > > -- > > Jazz is not dead. It just smells funny...