From: Bjorn Helgaas <helgaas@kernel.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>,
Christoph Hellwig <hch@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ben Widawsky <ben.widawsky@intel.com>,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH V7 03/10] PCI: Create PCI library functions in support of DOE mailboxes.
Date: Thu, 7 Apr 2022 11:01:16 -0500 [thread overview]
Message-ID: <20220407160116.GA239672@bhelgaas> (raw)
In-Reply-To: <Yk4EvRDd/Kw5rEil@iweiny-desk3>
On Wed, Apr 06, 2022 at 02:23:09PM -0700, Ira Weiny wrote:
> On Wed, Apr 06, 2022 at 11:11:10AM +0100, Jonathan Cameron wrote:
> > On Tue, 5 Apr 2022 16:22:11 -0700
> > Ira Weiny <ira.weiny@intel.com> wrote:
> > > On Sat, Apr 02, 2022 at 04:48:45PM +0200, Lukas Wunner wrote:
> > > > On Thu, Mar 31, 2022 at 08:19:56AM -0700, Ira Weiny wrote:
> > > > > On Wed, Mar 30, 2022 at 10:50:31PM -0700, Christoph Hellwig wrote:
> > > > > > On Wed, Mar 30, 2022 at 04:59:13PM -0700, ira.weiny@intel.com wrote:
> > > > > > > Introduced in a PCI v6.0[1], DOE provides a config space based mailbox
> > > > > > > with standard protocol discovery. Each mailbox is accessed through a
> > > > > > > DOE Extended Capability.
> > > > > >
> > > > > > I really don't think this should be built unconditionally and bloat
> > > > > > every single kernel built with PCI support.
> > > > >
> > > > > I can add a Kconfig.
> > > >
> > > > Ideally, that config option should live in the pcie/ subdirectory,
> > > > i.e. in drivers/pci/pcie/Kconfig, alongside drivers/pci/pcie/doe.c,
> > > > as we try to consolidate PCIe-specific features there and reserve
> > > > core code in drivers/pci/*.c for functionality that also applies
> > > > to Conventional PCI.
> > >
> > > Thanks for letting me know about this direction. I was unaware of this.
> >
> > We had this in the pcie directory, but Bjorn asked us to move it to the pci
> > directory as there isn't anything specific to PCIe about DOE. You could
> > implement it on pci-x (maybe 2.0?) I think even though it's in the PCIe specification.
> >
> > https://lore.kernel.org/linux-pci/20210413194927.GA2241331@bjorn-Precision-5520/
>
> :-/
>
> I'd forgotten that far back.
>
> Bjorn?
I would still prefer it in drivers/pci because I don't think
there's enough value to justify the pcie/ subdirectory. We have
ats.c, ecam.c, iov.c, pci-pf-stub.c, and vc.c in drivers/pci even
though they're PCIe-specific. Other files in drivers/pci like
access.c, pci-acpi.c, pci.c, probe.c, etc also have some PCIe
content.
Bjorn
next prev parent reply other threads:[~2022-04-07 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 23:59 [PATCH V7 00/10] CXL: Read CDAT and DSMAS data from the device ira.weiny
2022-03-30 23:59 ` [PATCH V7 01/10] PCI: Add vendor ID for the PCI SIG ira.weiny
2022-03-30 23:59 ` [PATCH V7 02/10] PCI: Replace magic constant for PCI Sig Vendor ID ira.weiny
2022-03-30 23:59 ` [PATCH V7 03/10] PCI: Create PCI library functions in support of DOE mailboxes ira.weiny
2022-03-31 5:50 ` Christoph Hellwig
2022-03-31 15:19 ` Ira Weiny
2022-04-02 14:48 ` Lukas Wunner
2022-04-05 23:22 ` Ira Weiny
2022-04-06 10:11 ` Jonathan Cameron
2022-04-06 21:23 ` Ira Weiny
2022-04-07 16:01 ` Bjorn Helgaas [this message]
2022-03-30 23:59 ` [PATCH V7 04/10] cxl/pci: Create auxiliary devices for each DOE mailbox ira.weiny
2022-04-29 15:33 ` Jonathan Cameron
2022-03-30 23:59 ` [PATCH V7 05/10] cxl/pci: Create DOE auxiliary driver ira.weiny
2022-03-30 23:59 ` [PATCH V7 06/10] cxl/pci: Find the DOE mailbox which supports CDAT ira.weiny
2022-03-30 23:59 ` [PATCH V7 07/10] cxl/mem: Read CDAT table ira.weiny
2022-03-30 23:59 ` [PATCH V7 08/10] cxl/cdat: Introduce cxl_cdat_valid() ira.weiny
2022-03-30 23:59 ` [PATCH V7 09/10] cxl/mem: Retry reading CDAT on failure ira.weiny
2022-03-30 23:59 ` [PATCH V7 10/10] cxl/port: Parse out DSMAS data from CDAT table ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407160116.GA239672@bhelgaas \
--to=helgaas@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).