From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 15/26] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent'
Date: Thu, 12 May 2022 20:49:25 +0530 [thread overview]
Message-ID: <20220512151925.GL35848@thinkpad> (raw)
In-Reply-To: <20220503225104.12108-16-Sergey.Semin@baikalelectronics.ru>
On Wed, May 04, 2022 at 01:50:53AM +0300, Serge Semin wrote:
> Since we are about to add the eDMA channels direction support to the
> debugfs module it will be confusing to have both the DebugFS directory and
> the channels direction short names used in the same code. As a preparation
> patch let's convert the DebugFS dentry 'dir' variables to having the
> 'dent' name so to prevent the confusion.
>
> Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
>
> ---
>
> Changelog v2:
> - This is a new patch added in v2. (@Manivannan)
> ---
> drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 46 ++++++++++++------------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> index 78f15e4b07ac..7bb3363b40e4 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-debugfs.c
> @@ -96,7 +96,7 @@ static int dw_edma_debugfs_u32_get(void *data, u64 *val)
> DEFINE_DEBUGFS_ATTRIBUTE(fops_x32, dw_edma_debugfs_u32_get, NULL, "0x%08llx\n");
>
> static void dw_edma_debugfs_create_x32(const struct dw_edma_debugfs_entry ini[],
> - int nr_entries, struct dentry *dir)
> + int nr_entries, struct dentry *dent)
> {
> struct dw_edma_debugfs_entry *entries;
> int i;
> @@ -109,13 +109,13 @@ static void dw_edma_debugfs_create_x32(const struct dw_edma_debugfs_entry ini[],
> for (i = 0; i < nr_entries; i++) {
> entries[i] = ini[i];
>
> - debugfs_create_file_unsafe(entries[i].name, 0444, dir,
> + debugfs_create_file_unsafe(entries[i].name, 0444, dent,
> &entries[i], &fops_x32);
> }
> }
>
> static void dw_edma_debugfs_regs_ch(struct dw_edma_v0_ch_regs __iomem *regs,
> - struct dentry *dir)
> + struct dentry *dent)
> {
> const struct dw_edma_debugfs_entry debugfs_regs[] = {
> REGISTER(ch_control1),
> @@ -131,10 +131,10 @@ static void dw_edma_debugfs_regs_ch(struct dw_edma_v0_ch_regs __iomem *regs,
> int nr_entries;
>
> nr_entries = ARRAY_SIZE(debugfs_regs);
> - dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, dir);
> + dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, dent);
> }
>
> -static void dw_edma_debugfs_regs_wr(struct dentry *dir)
> +static void dw_edma_debugfs_regs_wr(struct dentry *dent)
> {
> const struct dw_edma_debugfs_entry debugfs_regs[] = {
> /* eDMA global registers */
> @@ -171,34 +171,34 @@ static void dw_edma_debugfs_regs_wr(struct dentry *dir)
> WR_REGISTER_UNROLL(ch6_pwr_en),
> WR_REGISTER_UNROLL(ch7_pwr_en),
> };
> - struct dentry *regs_dir, *ch_dir;
> + struct dentry *regs_dent, *ch_dent;
> int nr_entries, i;
> char name[16];
>
> - regs_dir = debugfs_create_dir(WRITE_STR, dir);
> + regs_dent = debugfs_create_dir(WRITE_STR, dent);
>
> nr_entries = ARRAY_SIZE(debugfs_regs);
> - dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, regs_dir);
> + dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, regs_dent);
>
> if (dw->chip->mf == EDMA_MF_HDMA_COMPAT) {
> nr_entries = ARRAY_SIZE(debugfs_unroll_regs);
> dw_edma_debugfs_create_x32(debugfs_unroll_regs, nr_entries,
> - regs_dir);
> + regs_dent);
> }
>
> for (i = 0; i < dw->wr_ch_cnt; i++) {
> snprintf(name, sizeof(name), "%s:%d", CHANNEL_STR, i);
>
> - ch_dir = debugfs_create_dir(name, regs_dir);
> + ch_dent = debugfs_create_dir(name, regs_dent);
>
> - dw_edma_debugfs_regs_ch(®s->type.unroll.ch[i].wr, ch_dir);
> + dw_edma_debugfs_regs_ch(®s->type.unroll.ch[i].wr, ch_dent);
>
> lim[0][i].start = ®s->type.unroll.ch[i].wr;
> lim[0][i].end = ®s->type.unroll.ch[i].padding_1[0];
> }
> }
>
> -static void dw_edma_debugfs_regs_rd(struct dentry *dir)
> +static void dw_edma_debugfs_regs_rd(struct dentry *dent)
> {
> const struct dw_edma_debugfs_entry debugfs_regs[] = {
> /* eDMA global registers */
> @@ -236,27 +236,27 @@ static void dw_edma_debugfs_regs_rd(struct dentry *dir)
> RD_REGISTER_UNROLL(ch6_pwr_en),
> RD_REGISTER_UNROLL(ch7_pwr_en),
> };
> - struct dentry *regs_dir, *ch_dir;
> + struct dentry *regs_dent, *ch_dent;
> int nr_entries, i;
> char name[16];
>
> - regs_dir = debugfs_create_dir(READ_STR, dir);
> + regs_dent = debugfs_create_dir(READ_STR, dent);
>
> nr_entries = ARRAY_SIZE(debugfs_regs);
> - dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, regs_dir);
> + dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, regs_dent);
>
> if (dw->chip->mf == EDMA_MF_HDMA_COMPAT) {
> nr_entries = ARRAY_SIZE(debugfs_unroll_regs);
> dw_edma_debugfs_create_x32(debugfs_unroll_regs, nr_entries,
> - regs_dir);
> + regs_dent);
> }
>
> for (i = 0; i < dw->rd_ch_cnt; i++) {
> snprintf(name, sizeof(name), "%s:%d", CHANNEL_STR, i);
>
> - ch_dir = debugfs_create_dir(name, regs_dir);
> + ch_dent = debugfs_create_dir(name, regs_dent);
>
> - dw_edma_debugfs_regs_ch(®s->type.unroll.ch[i].rd, ch_dir);
> + dw_edma_debugfs_regs_ch(®s->type.unroll.ch[i].rd, ch_dent);
>
> lim[1][i].start = ®s->type.unroll.ch[i].rd;
> lim[1][i].end = ®s->type.unroll.ch[i].padding_2[0];
> @@ -269,16 +269,16 @@ static void dw_edma_debugfs_regs(void)
> REGISTER(ctrl_data_arb_prior),
> REGISTER(ctrl),
> };
> - struct dentry *regs_dir;
> + struct dentry *regs_dent;
> int nr_entries;
>
> - regs_dir = debugfs_create_dir(REGISTERS_STR, dw->debugfs);
> + regs_dent = debugfs_create_dir(REGISTERS_STR, dw->debugfs);
>
> nr_entries = ARRAY_SIZE(debugfs_regs);
> - dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, regs_dir);
> + dw_edma_debugfs_create_x32(debugfs_regs, nr_entries, regs_dent);
>
> - dw_edma_debugfs_regs_wr(regs_dir);
> - dw_edma_debugfs_regs_rd(regs_dir);
> + dw_edma_debugfs_regs_wr(regs_dent);
> + dw_edma_debugfs_regs_rd(regs_dent);
> }
>
> void dw_edma_v0_debugfs_on(struct dw_edma *_dw)
> --
> 2.35.1
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-05-12 15:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 22:50 [PATCH v2 00/26] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-05-03 22:50 ` [PATCH v2 01/26] dma-direct: take dma-ranges/offsets into account in resource mapping Serge Semin
2022-05-09 6:15 ` Christoph Hellwig
2022-05-12 23:28 ` Serge Semin
2022-05-03 22:50 ` [PATCH v2 02/26] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2022-05-12 14:18 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 03/26] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2022-05-12 14:39 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 04/26] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2022-05-03 22:50 ` [PATCH v2 05/26] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2022-05-03 22:50 ` [PATCH v2 06/26] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2022-05-12 14:41 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 07/26] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2022-05-12 15:16 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 08/26] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2022-05-03 22:50 ` [PATCH v2 09/26] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2022-05-03 22:50 ` [PATCH v2 10/26] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2022-05-03 22:50 ` [PATCH v2 11/26] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2022-05-03 22:50 ` [PATCH v2 12/26] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2022-05-03 22:50 ` [PATCH v2 13/26] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2022-05-03 22:50 ` [PATCH v2 14/26] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2022-05-12 15:17 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 15/26] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2022-05-12 15:19 ` Manivannan Sadhasivam [this message]
2022-05-03 22:50 ` [PATCH v2 16/26] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2022-05-12 15:20 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 17/26] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2022-05-03 22:50 ` [PATCH v2 18/26] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2022-05-03 22:50 ` [PATCH v2 19/26] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2022-05-03 22:50 ` [PATCH v2 20/26] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2022-05-12 15:21 ` Manivannan Sadhasivam
2022-05-03 22:50 ` [PATCH v2 21/26] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2022-05-03 22:51 ` [PATCH v2 22/26] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2022-05-03 22:51 ` [PATCH v2 23/26] dmaengine: dw-edma: Bypass dma-ranges mapping for the local setup Serge Semin
2022-05-24 13:19 ` Manivannan Sadhasivam
2022-05-25 8:56 ` Serge Semin
2022-05-03 22:51 ` [PATCH v2 24/26] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2022-05-12 15:23 ` Manivannan Sadhasivam
2022-05-12 17:38 ` Serge Semin
2022-05-03 22:51 ` [PATCH v2 25/26] PCI: dwc: Add generic iATU/eDMA CSRs space detection method Serge Semin
2022-05-03 22:51 ` [PATCH v2 26/26] PCI: dwc: Add DW eDMA engine support Serge Semin
2022-05-12 14:11 ` [PATCH v2 00/26] dmaengine: dw-edma: Add RP/EP local DMA controllers support Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512151925.GL35848@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).