From: Bjorn Helgaas <helgaas@kernel.org>
To: Shunsuke Mie <mie@igel.co.jp>
Cc: "Kishon Vijay Abraham I" <kishon@ti.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Hou Zhiqiang" <Zhiqiang.Hou@nxp.com>,
"Li Chen" <lchen@ambarella.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Don't stop EP controller by EP function
Date: Wed, 22 Jun 2022 16:01:55 -0500 [thread overview]
Message-ID: <20220622210155.GA1392911@bhelgaas> (raw)
In-Reply-To: <20220622040924.113279-1-mie@igel.co.jp>
On Wed, Jun 22, 2022 at 01:09:24PM +0900, Shunsuke Mie wrote:
> For multi-function endpoint device, an ep function shouldn't stop EP
> controller. Nomally the controller is stopped via configfs.
>
> Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
Fixed typo and applied with Kishon's ack to pci/endpoint for v5.20, thanks!
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 5b833f00e980..a5ed779b0a51 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -627,7 +627,6 @@ static void pci_epf_test_unbind(struct pci_epf *epf)
>
> cancel_delayed_work(&epf_test->cmd_handler);
> pci_epf_test_clean_dma_chan(epf_test);
> - pci_epc_stop(epc);
> for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
> epf_bar = &epf->bar[bar];
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-06-22 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 4:09 [PATCH] PCI: endpoint: Don't stop EP controller by EP function Shunsuke Mie
2022-06-22 5:10 ` Kishon Vijay Abraham I
2022-06-22 5:23 ` Shunsuke Mie
2022-06-22 21:01 ` Bjorn Helgaas [this message]
2022-07-05 22:40 ` Bjorn Helgaas
2022-07-06 2:37 ` Shunsuke Mie
2022-07-06 3:08 ` Bjorn Helgaas
2022-07-06 3:15 ` Shunsuke Mie
2022-07-06 20:25 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622210155.GA1392911@bhelgaas \
--to=helgaas@kernel.org \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=lchen@ambarella.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mie@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).