From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5108C43334 for ; Fri, 24 Jun 2022 03:39:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbiFXDjg (ORCPT ); Thu, 23 Jun 2022 23:39:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231405AbiFXDjL (ORCPT ); Thu, 23 Jun 2022 23:39:11 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C612663627; Thu, 23 Jun 2022 20:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656041940; x=1687577940; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NtFtE7qW+K5DUFG3lDhxsR2HkHFGEJGYMaA9IZdhYVk=; b=Iwd3XBgCoSN77GT6585Z+0YoEPJFmuARIr3MmaVtX3W4l6nDcIEH572x KSArrxoytf0MSWrwMl7OrH4f1jxHaBRr+RqdvBex/A9bODLt69+ttUr+h 3Zu+pFbVJPMSlYmp/GAi7jz3BrZ/cVATYHoHh0d1xZ7d5lUTTWJquLxFt EyR+okqqeJQd8zaAKRMLeK72DmGOPsCAbjqkH5e6l+Z6c3l9Yz+FEJDVd lDMPhyXMXviBSIntQiZWGSjsRJ9uyJIEp5z0yaT+VLSWIa1eCoJZWzi1C NKnVMq8z5QxdY778l3Sc5nGFxGgaNoJeQzVH+D+HLjCTaYQIpnXRFrCG0 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="261339952" X-IronPort-AV: E=Sophos;i="5.92,217,1650956400"; d="scan'208";a="261339952" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 20:39:00 -0700 X-IronPort-AV: E=Sophos;i="5.92,217,1650956400"; d="scan'208";a="645080505" Received: from alison-desk.jf.intel.com (HELO alison-desk) ([10.54.74.41]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 20:39:00 -0700 Date: Thu, 23 Jun 2022 20:38:24 -0700 From: Alison Schofield To: "Williams, Dan J" Cc: "linux-cxl@vger.kernel.org" , Ben Widawsky , "hch@infradead.org" , "nvdimm@lists.linux.dev" , "linux-pci@vger.kernel.org" , "patches@lists.linux.dev" Subject: Re: [PATCH 03/46] cxl/hdm: Use local hdm variable Message-ID: <20220624033824.GB1558591@alison-desk> References: <165603869943.551046.3498980330327696732.stgit@dwillia2-xfh> <165603872171.551046.913207574344536475.stgit@dwillia2-xfh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165603872171.551046.913207574344536475.stgit@dwillia2-xfh> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jun 23, 2022 at 07:45:21PM -0700, Dan Williams wrote: > From: Ben Widawsky > > Save a few characters and use the already initialized local variable. > > Signed-off-by: Ben Widawsky > Signed-off-by: Dan Williams Reviewed-by: Alison Schofield > --- > drivers/cxl/core/hdm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c > index bfc8ee876278..ba3d2d959c71 100644 > --- a/drivers/cxl/core/hdm.c > +++ b/drivers/cxl/core/hdm.c > @@ -251,8 +251,7 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm) > return PTR_ERR(cxld); > } > > - rc = init_hdm_decoder(port, cxld, target_map, > - cxlhdm->regs.hdm_decoder, i); > + rc = init_hdm_decoder(port, cxld, target_map, hdm, i); > if (rc) { > put_device(&cxld->dev); > failed++; >