From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Frank Li" <Frank.Li@nxp.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
imx@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 4/5] PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro
Date: Wed, 17 Apr 2024 06:14:35 -0500 [thread overview]
Message-ID: <20240417111435.GA187921@bhelgaas> (raw)
In-Reply-To: <20240417075655.GF3894@thinkpad>
On Wed, Apr 17, 2024 at 01:26:55PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Apr 16, 2024 at 12:02:42PM -0500, Bjorn Helgaas wrote:
> > On Mon, Apr 15, 2024 at 03:33:28PM -0400, Frank Li wrote:
> > > Add PCIE_MSG_CODE_PME_TURN_OFF macros to enable a PCIe host driver to send
> > > PME_Turn_Off messages.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > drivers/pci/pci.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> > > index 19b4227a8a7e8..1f6d54a5a7cfc 100644
> > > --- a/drivers/pci/pci.h
> > > +++ b/drivers/pci/pci.h
> > > @@ -30,6 +30,8 @@
> > > #define PCIE_MSG_TYPE_R_LOCAL 4
> > > #define PCIE_MSG_TYPE_R_GATHER 5
> > >
> > > +#define PCIE_MSG_CODE_PME_TURN_OFF 0x19
> >
> > This is defined in PCIe r6.0, sec 2.2.8.2, so move this below the INTx
> > #defines so they're all in the order of the spec sections and add the
>
> I think it was me who suggested moving this up to keep it sorted in ascending
> order :/
OK, the order you suggested is fine.
> > spec citation to follow the same style as the surrounding #defines,
> > i.e.,
> >
> > /* Power Management Messages; PCIe r6.0, sec 2.2.8.2 */
> > #define PCIE_MSG_CODE_PME_TURN_OFF 0x19
> >
> > While you're at it, tweak the [1/5] comments to be:
> >
> > /* Message Routing (r[2:0]); PCIe r6.0, sec 2.2.8 */
> > /* INTx Mechanism Messages; PCIe r6.0, sec 2.2.8.1 */
> >
> > since the "Message Routing See: PCIe ..." comments are run together
> > and need some punctuation between the text and the citation.
But please do add and tweak the comments.
> > With these,
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Still fine to add this :)
> > > /* INTx Mechanism Messages See: PCIe r6.0, sec 2.2.8.1 */
> > > #define PCIE_MSG_CODE_ASSERT_INTA 0x20
> > > #define PCIE_MSG_CODE_ASSERT_INTB 0x21
> > >
> > > --
> > > 2.34.1
> > >
>
> --
> மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-04-17 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 19:33 [PATCH v6 0/5] PCI: dwc: Add common pme_turn_off message by using outbound iATU Frank Li
2024-04-15 19:33 ` [PATCH v6 1/5] PCI: Add INTx Mechanism Messages macros Frank Li
2024-04-15 19:33 ` [PATCH v6 2/5] PCI: dwc: Consolidate args of dw_pcie_prog_outbound_atu() into a structure Frank Li
2024-04-15 19:33 ` [PATCH v6 3/5] PCI: dwc: Add outbound MSG TLPs support Frank Li
2024-04-15 19:33 ` [PATCH v6 4/5] PCI: Add PCIE_MSG_CODE_PME_TURN_OFF message macro Frank Li
2024-04-16 17:02 ` Bjorn Helgaas
2024-04-17 7:56 ` Manivannan Sadhasivam
2024-04-17 11:14 ` Bjorn Helgaas [this message]
2024-04-15 19:33 ` [PATCH v6 5/5] PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off when system suspend Frank Li
2024-04-17 10:19 ` Manivannan Sadhasivam
2024-04-17 14:38 ` Frank Li
2024-04-17 14:52 ` Manivannan Sadhasivam
2024-04-17 15:10 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417111435.GA187921@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).